ORK Framework Static Analysis

# Common Practices and Code Improvements

## Empty statement is redundant

Extra ;

Solution ORK Framework 3.sln
    Project Framework
      Framework\Gameplay\BattleSystem\Settings\Chances\CriticalChance.cs:83
      Framework\UI\Settings\MenuScreen\Settings\GroupMenuItem.cs:154



## 'value' parameter is not used

set { this.followLeaderCombatant = null; }

this might supposed to be

set { this.followLeaderCombatant = value; }

Solution ORK Framework 3.sln
    Project Framework
      Framework\Components\Combatants\MoveAI\MoveAIComponent.cs:666
      Framework\Gameplay\AI\AIEquipment\AIBehaviourSlot.cs:43
      Framework\Gameplay\AI\AIEquipment\AIRulesetSlot.cs:43



## Content of collection 'list' is only updated but never used

Solution ORK Framework 3.sln
    Project Framework
      Framework\Gameplay\Status\Bonuses\RandomStatusBonusSettings.cs:71



## Possible loss of fraction

Solution ORK Framework 3.sln
    Project Framework
      Framework\Gameplay\Base\Formula\Nodes\CombatantFormulaNodes.cs:1046



## Multiplication by 0 in every execution path

int buyPrice = 0;
int sellPrice = 0;

ORK.TextDisplaySettings.priceText.GetBuyText(currency, buyPrice * priceQuantity),
ORK.TextDisplaySettings.priceText.GetSellText(currency, sellPrice * priceQuantity),

Solution ORK Framework 3.sln
    Project Framework
      Framework\Gameplay\Base\Language\Layout\ORKSlotContentLayout.cs:400
      Framework\Gameplay\Base\Language\Layout\ORKSlotContentLayout.cs:401



## 'ContainsKey' call is redundant before adding the item to the dictionary

if(this.playerSpotList.ContainsKey(spot))
{
    this.playerSpotList[spot] = combatant;
}
else
{
    this.playerSpotList.Add(spot, combatant);
}

to

this.playerSpotList[spot] = combatant;

Solution ORK Framework 3.sln
    Project Framework
      Framework\Components\Battles\BattleComponent.cs:1017
      Framework\Components\Battles\BattleComponent.cs:1092
      Framework\Components\Battles\BattleComponent.cs:1167
      Framework\Components\Battles\BattleGridCellComponent.cs:655
      Framework\Components\Battles\BattleGridCellComponent.cs:672
      Framework\Gameplay\BattleSystem\TargetSelections\SelectedTargets.cs:380
      Framework\Gameplay\Combatants\Combatant\CombatantObject.cs:674
      Framework\Gameplay\Shortcuts\ClassShortcut.cs:1000
      Framework\Gameplay\World\Scene\ORKSceneData.cs:222
      Framework\Handler\ORKSceneHandler.cs:667
      Framework\Handler\ORKSceneHandler.cs:737
      Framework\Handler\QuestHandler.cs:269
      Framework\UI\Settings\Battle\BattleMenu\ActiveBattleMenu.cs:1368
      Framework\UI\Settings\Battle\BattleMenu\ActiveBattleMenu.cs:1379
      Framework\UI\Settings\Battle\BattleMenu\ActiveBattleMenu.cs:1390
      Framework\UI\Settings\Battle\BattleMenu\ActiveBattleMenu.cs:1401
      Framework\UI\Settings\MenuScreen\Parts\AbilityMenuPart.cs:1066
      Framework\UI\Settings\MenuScreen\Parts\AIBehaviourMenuPart.cs:1188
      Framework\UI\Settings\MenuScreen\Parts\AIRulesetMenuPart.cs:1186
      Framework\UI\Settings\MenuScreen\Parts\BestiaryAreaMenuPart.cs:1226
      Framework\UI\Settings\MenuScreen\Parts\BestiaryTypeMenuPart.cs:903
      Framework\UI\Settings\MenuScreen\Parts\CraftingMenuPart.cs:959
      Framework\UI\Settings\MenuScreen\Parts\InventoryExchangeMenuPart.cs:887
      Framework\UI\Settings\MenuScreen\Parts\InventoryMenuPart.cs:1068
      Framework\UI\Settings\MenuScreen\Parts\LogMenuPart.cs:826
      Framework\UI\Settings\MenuScreen\Parts\MultiContentMenuPart.cs:1078
      Framework\UI\Settings\MenuScreen\Parts\MultiSlotMenuPart.cs:1324
      Framework\UI\Settings\MenuScreen\Parts\QuestMenuPart.cs:999
      Framework\UI\Settings\MenuScreen\Parts\ResearchMenuPart.cs:1822
      Framework\UI\Settings\MenuScreen\Parts\ResearchTreeViewMenuPart.cs:1646
      Framework\UI\Settings\MenuScreen\Parts\SingleSlotMenuPart.cs:871
      Framework\UI\Settings\MenuScreen\Parts\TeleportMenuPart.cs:691