FACTION_TEMPLATE_FLAG_PVP

[12:11:28] <Aokromes> Shauren he is asking because https://pastebin.com/4bN6q219
[12:13:04] <Shauren> i said structures
[12:13:07] <Shauren> not flag values
[12:14:08] <Shauren> also its this one doing the healability thing
[12:14:13] <Shauren> UNIT_FIELD_BYTES_1: 8
[12:14:15] <Aokromes> Riztazz https://i.imgur.com/MIKkrPg.jpg i cannot heal guy on left (i get heal cast on myself) i can heal guy on right xd
[12:14:19] <Shauren> thats pvp is im not mistaken
[12:14:56] <Aokromes> [11:52:56] <Malcrom1> The spell system in tc is preventing healing spells on that faction
[12:14:56] <Aokromes> [11:53:22] <Malcrom1> If you change the npc faction you can cast on them
[12:15:48] <Shauren> my mistake
[12:15:50] <Shauren> its this one
[12:15:50] <Shauren> UNIT_FIELD_BYTES_2: 257
[12:16:04] <Shauren> it has UNIT_BYTE2_FLAG_PVP set so you can heal it
[12:16:16] <Shauren> obviously depends on faction
[12:22:56] <Aokromes> maybe name is incorrect?
[12:25:42] [ Join ] joschiwald ([email protected])
[12:25:42] [ MODOS ] TRiNiTY pone +h joschiwald
[12:29:39] <vincent-michael> http://www.aviationtoday.com/2017/11/08/boeing-757-testing-shows-airplanes-vulnerable-hacking-dhs-says/
[12:34:24] * Treeston ([email protected]) Quit (Read error: Connection reset by peer)
[12:35:53] <Riztazz> https://twitter.com/realDonaldTrump/status/929511061954297857
[12:37:50] * Mihapro ([email protected]) Quit (Ping timeout: 240 seconds)
[12:38:32] <WardenX> TrinityCore/TrinityCore (9b7c73a * 3.3.5): jackpoz committed Core/Misc: Fix static analysis issues https://git.io/vFw9a
[12:41:21] <Aokromes> UNIT_FIELD_BYTES_2	122	creature_addon.bytes2
[12:41:23] <Aokromes> soo
[12:41:39] <Aokromes> it's add that to c_a / c_t_a instead we are doing to unit_field
[12:41:53] <Killerwife> Aokromes
[12:41:54] <Killerwife> https://github.com/cmangos/mangos-wotlk/commit/d3aa99fa9bf88c53b319154ee6c402ce9bf685ed
[12:42:09] <Shauren> nope
[12:42:19] <Shauren> c_a && c_t_a ignore that part of bytes
[12:42:32] <Aokromes> why?
[12:43:22] <Shauren> because its controlled by faction
[12:43:31] <Shauren> currently with this line of code
[12:43:31] <Shauren>         SetPvP((factionTemplate->factionFlags & FACTION_TEMPLATE_FLAG_PVP) != 0);
[12:45:51] <Killerwife> clientside its controlled by a plethora of factors, PVP flag is just one thing out of those, propably server/client logic desync + bad data?
[12:46:03] <Shauren> eh
[12:47:05] <Shauren> whats up with you mangos guys being afraid of creating new classes or files (having functions of one class in multiple files is really horrible, just as having giant classes (tc suffers from this as well))
[12:47:23] <Killerwife> the commit i linked made new file
[12:47:28] <Killerwife> kinda bad example?
[ WHOIS ] Killerwife
[ Killerwife ] [email protected] : Killerwife
[ Killerwife ] #trinity @#cmangos #vengeancewow.testers @#voa_testers
[ Killerwife ] *.rizon.net Where are you?
[12:48:02] <Aokromes> Killerwife that commit allows to heal those npcs without having to hack flags?
[12:48:20] <Killerwife> yes but a core wide restructuring of calls was needed
[12:48:23] <Killerwife> I spent 3 months on it
[12:48:34] <Killerwife> I can now use sniff 1:1 flags and everything works like on retail
[12:48:46] <Aokromes> hmm
[12:48:53] <Aokromes> it works also with scholazar basin mobs?
[12:49:07] <Killerwife> that much I can't tell, I am mostly based on tbc
[12:49:35] <Shauren> Aokromes: ill remind you that we used to have client reversed functions too and "multiple people" broke it with extra checks
[12:49:53] <Killerwife> yes but WB strictly didnt alter the clientside ones
[12:50:18] <Shauren> Unit::_IsValidAssistTarget was supposed to mirror CGUnit_C::CanAssist
[12:50:59] <Killerwife> yeah but you spliced it with spell logic
[12:51:09] <Killerwife> client CanAssist doesnt have spell logic