Advertisement
olerem

My mail to ASUS.

Apr 22nd, 2017
279
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 2.75 KB | None | 0 0
  1. Hallo,
  2.  
  3. On my new o UX330 i discovered issue related to Ambient Light Sensor (ALS).
  4. On ASUS laptops ALS is usually disabled by default and BIOS provides ASUS WMI interface to set the state to enable or disable and to get current state.
  5.  
  6. On all my laptops Asus UX31A, UX302LA and UX330UA the SET function works as expected. The GET function is broken on UX330.
  7. After comparing BIOS DSDT of UX330 and UX31A I found that there is a typo I the UX330 BIOS:
  8. Method (WMNB, 3, Serialized)
  9. {
  10. ...
  11. If (Local0 == 0x53545344)
  12. {
  13. ...
  14. If (IIA0 == 0x00050001)
  15. {
  16. If (!ALSP)
  17. {
  18. Return (0x02)
  19. }
  20.  
  21. Local0 = (GALS & 0x10) <<<---- bug,
  22. should be: (GALS () & 0x10)
  23. If (Local0)
  24. {
  25. Return (0x00050001)
  26. }
  27. Else
  28. {
  29. Return (0x00050000)
  30. }
  31. }
  32.  
  33. .....
  34. If (Local0 == 0x53564544)
  35. {
  36. ...
  37. If (IIA0 == 0x00050001)
  38. {
  39. Return (ALSC (IIA1))
  40. }
  41.  
  42.  
  43. the same part on UX32A:
  44. If ((IIA0 == 0x00050001))
  45. {
  46. If (!ALSP)
  47. {
  48. Return (0x02)
  49. }
  50.  
  51. Local0 = (GALS () & 0x10) <<←-- not a bug.
  52. If (Local0)
  53. {
  54. Return (0x00050001)
  55. }
  56. Else
  57. {
  58. Return (0x00050000)
  59. }
  60. }
  61.  
  62. If ((IIA0 == 0x00050013))
  63. {
  64. Local0 = (GALS () & 0x0F0F)
  65. Return (Local0)
  66. }
  67.  
  68.  
  69. Since on Linux we test GET method first and if it fails not trying to use SET method, the ASUS UX330 model has not enabled Ambient Light Sensor.
  70. I provided a patch to enable Ambient Light Sensor by default even if GET method will fail (with the hope it will not brake support for other ASUS devices), so this issue theoretically will be solved in coming Linux distributions.
  71.  
  72. In any case it will be good if ASUS will fix BIOS as well.
  73.  
  74. If you need more technical information pleas contact me.
  75.  
  76. Best regards,
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement