Makinom Static Analysis

# Potential Code Quality Issues

## '?:' expression has identical true and false branches

Solution Makinom 2.sln
    Project Framework
      Framework\Gameplay\Base\Formula\Nodes\VariableFormulaNodes.cs:395



## Exception rethrow possibly intended

catch(ExitGUIException ex)
{
    throw ex;
}

to

catch(ExitGUIException ex)
{
    throw; // This preserves the stack trace
}



## Non-accessed field

Solution Makinom 2.sln
    Project Editor
      Editor\Tools\EditorAutomation.cs:501
      Editor\Tools\EditorAutomation.cs:525

Solution Makinom 2.sln
    Project Editor
      Editor\Tools\EditorContent.cs:130 Field 'labelWidth' is assigned but its value is never used

    Project Framework
      Framework\Data\Serialization\ByteData\FastByteDataReader.cs:15 Field '_length' is assigned but its value is never used



## Safe cast expression always succeeds, consider direct cast instead

ArrayHelper.Add(ref this.formula.Settings.setting.node, node as BaseFormulaNode);

to

ArrayHelper.Add(ref this.formula.Settings.setting.node, (BaseFormulaNode)node);

Solution Makinom 2.sln
    Project Editor
      Editor\FrameworkWindow\GameSection\FormulasTab.cs:395
      Editor\FrameworkWindow\GameSection\FormulasTab.cs:405
      Editor\FrameworkWindow\SchematicsSection\SchematicsTab.cs:434
      Editor\FrameworkWindow\SchematicsSection\SchematicsTab.cs:444



# Redundancies in Code

## 'ContainsKey' call is redundant before adding the item to the dictionary

if(data.ContainsKey(key))
{
    data[key] = value;
}
else
{
    data.Add(key, value);
}

to

data[key] = value;

This will automatically create the key if it doesn't exist.

Solution Makinom 2.sln
    Project Framework
      Framework\Data\Serialization\DataObject.cs:288
      Framework\Data\Serialization\DataObject.cs:942
      Framework\Gameplay\Audio\Music\MusicChannel.cs:227
      Framework\Gameplay\Values\Variables\VariabelListHandler.cs:1158
      Framework\Gameplay\Values\Variables\VariabelListHandler.cs:1176
      Framework\Gameplay\Values\Variables\VariabelListHandler.cs:1194
      Framework\Gameplay\Values\Variables\VariabelListHandler.cs:1212
      Framework\Gameplay\Values\Variables\VariabelListHandler.cs:1230
      Framework\Gameplay\Values\Variables\VariableHandler.cs:206
      Framework\Gameplay\Values\Variables\VariableHandler.cs:226
      Framework\Gameplay\Values\Variables\VariableHandler.cs:246
      Framework\Gameplay\Values\Variables\VariableHandler.cs:266
      Framework\Gameplay\Values\Variables\VariableHandler.cs:286
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1147
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1168
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1189
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1210
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1231
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1252
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1272
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1292
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1312
      Framework\Gameplay\Values\Variables\VariableHandler.cs:1332
      Framework\Gameplay\World\Scene\SceneData.cs:109
      Framework\Handler\FadeHandler.cs:52
      Framework\Handler\FadeHandler.cs:78
      Framework\Handler\GameHandler.cs:708
      Framework\Handler\SceneHandler.cs:251
      Framework\UI\Content\UIContent.cs:39
      Framework\UI\Content\UIPortrait.cs:31
      Framework\UI\Systems\Base\BaseUISystem.cs:94



## Code is heuristically unreachable

else if(value is Transform)
{
    return ((Transform)value).gameObject;
}

Transform doesn't inherit from object so this will never be true

Solution Makinom 2.sln
    Project Framework
      Framework\Tools\ComponentHelper.cs:65
      Framework\Tools\ComponentHelper.cs:139



## Redundant check before assignment

Solution Makinom 2.sln
    Project Editor
      Editor\FrameworkWindow\BaseEditorTab.cs:629

    Project UnityUI
      UISystems\UnityUI\UISystem\Components\HUDs\HUDComponent.cs:244
      UISystems\UnityUI\UISystem\Components\UIBox\UIBoxComponent.cs:212
      UISystems\UnityUI\UISystem\Components\UIBox\UIBoxComponent.cs:224
      UISystems\UnityUI\UISystem\Components\UIBox\UIBoxComponent.cs:236



## Redundant conditional ternary expression usage

inRangeStatus = invert ? true : false;

to

inRangeStatus = invert;

Solution Makinom 2.sln
    Project Framework
      Framework\Gameplay\Values\Range\Range.cs:338
      Framework\Gameplay\Values\Range\Range.cs:350
      Framework\Gameplay\Values\Range\Range.cs:362
      Framework\Gameplay\Values\Range\RangeValue.cs:366
      Framework\Gameplay\Values\Range\RangeValue.cs:378
      Framework\Gameplay\Values\Range\RangeValue.cs:390