PVS-StudioWarnings

PVS-Studio warning V668 for Chromium

Nov 20th, 2014
179
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. bool NetworkStats::DoConnect(int result) {
  2.   ....
  3.   net::UDPClientSocket* udp_socket =
  4.       new net::UDPClientSocket(....);
  5.   if (!udp_socket) {
  6.     Finish(SOCKET_CREATE_FAILED, net::ERR_INVALID_ARGUMENT);
  7.     return false;
  8.   }
  9.   ....
  10. }
  11.  
  12. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V668 There is no sense in testing the 'udp_socket' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. network_stats.cc 212
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment