PVS-StudioWarnings

PVS-Studio warning V547 for IPP Samples

Nov 20th, 2014
159
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. Ipp32u m_iCurrMBIndex;
  2.  
  3. VC1EncoderMBInfo *
  4. VC1EncoderMBs::GetPevMBInfo(Ipp32s x, Ipp32s y)
  5. {
  6.    Ipp32s row = (y>0)? m_iPrevRowIndex:m_iCurrRowIndex;
  7.    return ((m_iCurrMBIndex - x <0 || row <0) ?
  8.           0 :
  9.           &m_MBInfo[row][m_iCurrMBIndex - x]);
  10. }
  11.  
  12. Since the check doesn't work, we may easily get an array overrun.
  13.  
  14. This suspicious code was found in IPP Samples project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V547 Expression 'm_iCurrMBIndex - x < 0' is always false. Unsigned type value is never < 0. vc1_enc umc_vc1_enc_mb.cpp 188
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment