PVS-StudioWarnings

PVS-Studio warning V593 for Wine

Nov 21st, 2014
157
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.67 KB | None | 0 0
  1. static HRESULT request_send( struct winhttp_request *request )
  2. {
  3.   if ((hr = SafeArrayAccessData( sa, (void **)&ptr )) != S_OK)
  4.     return hr;
  5.   if ((hr = SafeArrayGetUBound( sa, 1, &size ) != S_OK)) //<==
  6.   {
  7.     SafeArrayUnaccessData( sa );
  8.     return hr;
  9.   }
  10. }
  11.  
  12. This suspicious code was found in Wine project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V593 Consider reviewing the expression of the 'A = B != C' kind. The expression is calculated as following: 'A = (B != C)'. request.c 3354
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment