09:27:12 <+Grum> Hafydd: we managed to fix it, but not fix the issues that was really there because there was no way to know if it messed it up before :)
09:28:07 <+Grum> So the bug is fixed, but no way to undo the swap; but that is somewhat fine since snapshot -> snapshot is not really the goal
09:28:17 <Hafydd> Grum: well, FYI, it's still happening in 1.13. I can post a new issue, if necessary.
09:29:33 <+Grum> that would be somewhat strange, maybe I misremember, there is code that swaps 2 inventories
09:30:40 <Hafydd> Other tickets for the same issue are being marked as "resolved" because this one has the "won't fix" status.
09:32:03 <Hafydd> e.g. https://bugs.mojang.com/browse/MC-134195
09:36:17 <+Grum> I wonder if we only added swapping on borders hmz the issue is that the new doublechests exists of 2 chests, how do you know you have not already swapped it when you hit the other block? :D
09:39:32 <+Grum> so 2/4 orientations of doublechests had the contents stored the wrong way around in <1.13
09:41:54 <+Grum> but while upgrading a chunk you do you have the neighbour chunks
09:42:03 <+Grum> so you cannot actually swap anything
09:43:20 <Hafydd> So you'll need to obtain access to the neighbouring chunks, too.
09:43:28 <+Grum> which is not possible during the upgrade itself
09:43:32 <Hafydd> Why not?
09:43:47 <+Grum> because we update invididual elements of data, which in this case is a single chunks worth of data
09:43:53 <+Grum> there is *no* context at all but the data we have
09:44:26 <Hafydd> But surely it's *possible* to change the process so that you do?
09:44:35 <+Grum> no
09:45:14 <+Grum> absolutely everything of the datafixing setup has been created that you do not have context, else it ends up being tied into the game code again, which would be a *really* bad idea
09:46:11 <+Grum> it just means there are 1-2 things which you cannot recover from if you want to make a step to sanity
09:46:15 <Hafydd> Right, I'd call that "difficult", not "impossible".
09:46:18 <+Grum> and honestly, it really doesn't matter too much
09:46:31 <+Grum> No, it is designed not to do so because that solves a whole heap of other problems
09:46:45 <Hafydd> From the point of view of a user, though, all that's happening is that their world is getting messed up.
09:47:02 <+Grum> Agreed, but it was already messed up and now it is unmessed up :)
09:47:14 <+Grum> but yes, agreed, it is a bit strange
09:48:25 <+Grum> it i a bit strange, because there is code that should in theory handle it O.o
09:48:30 <+Grum> worth to look into