PVS-StudioWarnings

PVS-Studio warning V502 for Chromium

Nov 20th, 2014
181
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.74 KB | None | 0 0
  1. static const int kClientEdgeThickness;
  2.  
  3. int height() const;
  4.  
  5. bool ShouldShowClientEdge() const;
  6.  
  7. void CustomFrameView::PaintMaximizedFrameBorder(
  8.   gfx::Canvas* canvas)
  9. {
  10.   ...
  11.   int edge_height = titlebar_bottom->height() -
  12.     ShouldShowClientEdge() ? kClientEdgeThickness : 0;
  13.   ...
  14. }
  15.  
  16. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V502 Perhaps the '?:' operator works in a different way than it was expected. The '?:' operator has a lower priority than the '-' operator.  views  custom_frame_view.cc  400
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment