PVS-StudioWarnings

PVS-Studio warning V593 for Putty

Nov 11th, 2014
150
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.96 KB | None | 0 0
  1. static LRESULT CALLBACK WndProc(HWND hwnd, UINT message,
  2.   WPARAM wParam, LPARAM lParam)
  3. {
  4.   ....
  5.   if ((rc = p_GetSecurityInfo(filemap, SE_KERNEL_OBJECT,
  6.               OWNER_SECURITY_INFORMATION,
  7.               &mapowner, NULL, NULL, NULL,
  8.               &psd) != ERROR_SUCCESS))
  9.   {
  10.     #ifdef DEBUG_IPC
  11.       debug(("couldn't get owner info for filemap: %d\n", rc));
  12.     #endif
  13.       CloseHandle(filemap);
  14.       sfree(ourself);
  15.       sfree(ourself2);
  16.       return 0;
  17.   }
  18.   ....
  19. }
  20.  
  21. A minor problem. The program prints the wrong value in debug mode.
  22.  
  23. This suspicious code was found in Putty project by PVS-Studio static code analyzer.
  24. Warning message is:
  25. V593 Consider reviewing the expression of the 'A = B != C' kind. The expression is calculated as following: 'A = (B != C)'. winpgnt.c 1937
  26.  
  27. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment