PVS-StudioWarnings

PVS-Studio warning V579 for ReactOS

Nov 11th, 2014
175
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. typedef struct _HHIVE
  2. {
  3.   ...
  4. } HHIVE, *PHHIVE;
  5.  
  6. VOID
  7. CmGetSystemControlValues(....)
  8. {
  9.   PHHIVE SystemHive = (PHHIVE)&CmControlHive;
  10.   ...
  11.   RtlZeroMemory(SystemHive, sizeof(SystemHive));
  12.   ...
  13. }
  14.  
  15. Most likely this is what should be written here: RtlZeroMemory(SystemHive, sizeof(*SystemHive));
  16.  
  17. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  18. Warning message is:
  19. V579 The memset function receives the pointer and its size as arguments. It is possibly a mistake. Inspect the third argument. ntoskrnl cmcontrl.c 121
  20.  
  21. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment