PVS-StudioWarnings

PVS-Studio warning V501 for Firefox

Nov 19th, 2014
170
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. nsresult PresShell::SetResolution(float aXResolution,
  2.                                   float aYResolution)
  3. {
  4.   if (!(aXResolution > 0.0 && aXResolution > 0.0)) {
  5.     return NS_ERROR_ILLEGAL_VALUE;
  6.   }
  7.   ...
  8. }
  9.  
  10. This is what should have been written here: (aXResolution > 0.0 && aYResolution > 0.0)
  11.  
  12. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V501 There are identical sub-expressions to the left and to the right of the '&&' operator: aXResolution > 0.0 && aXResolution > 0.0 nspresshell.cpp 5114
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment