PVS-StudioWarnings

PVS-Studio warning V501 for Firefox

Nov 20th, 2014
158
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.77 KB | None | 0 0
  1. PRBool
  2. nsStyleAnimation::AddWeighted(....)
  3. {
  4.   ...
  5.   if (unit[0] == eCSSUnit_Null || unit[1] == eCSSUnit_Null ||
  6.       unit[0] == eCSSUnit_Null || unit[0] == eCSSUnit_URL) {
  7.     return PR_FALSE;
  8.   }
  9.   ...
  10. }
  11.  
  12. There seem to be 2 errors at once. The second line in the condition should look like this: unit[0] == eCSSUnit_URL || unit[1] == eCSSUnit_URL.
  13.  
  14. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V501 There are identical sub-expressions 'unit [0] == eCSSUnit_Null' to the left and to the right of the '||' operator. nsstyleanimation.cpp 1767
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment