PVS-StudioWarnings

PVS-Studio warning V547 for ACE

Nov 25th, 2014
165
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.57 KB | None | 0 0
  1. ACEXML_Char*
  2. ACEXML_Parser::parse_reference_name (void)
  3. {
  4.   ACEXML_Char ch = this->get ();
  5.   if (!this->isLetter (ch) && (ch != '_' || ch != ':'))
  6.     return 0;
  7.   ...
  8. }
  9.  
  10. This suspicious code was found in ACE project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V547 Expression 'ch != '_' || ch != ':'' is always true. Probably the '&&' operator should be used here. ACEXML_Parser parser.cpp 1905
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment