Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- enum ContentSettingsType;
- struct EntryMapKey {
- ContentSettingsType content_type;
- ...
- };
- bool OriginIdentifierValueMap::EntryMapKey::operator<(
- const OriginIdentifierValueMap::EntryMapKey& other) const {
- if (content_type < other.content_type)
- return true;
- else if (other.content_type > content_type)
- return false;
- return (resource_identifier < other.resource_identifier);
- }
- Most likely this is what should be written here: if (content_type > other.content_type) return false.
- This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
- Warning message is:
- V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 61, 63. browser content_settings_origin_identifier_value_map.cc 61
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment