Guest User

Untitled

a guest
Nov 22nd, 2018
133
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 2.21 KB | None | 0 0
  1. #Pull requests should be attachable to existing issues (in the web UI)
  2.  
  3. What the title says. Here's the use case:
  4.  
  5. 1. Alice opens an issue (say issue #123) on a repo.
  6. 2. Bob else takes that bug on and fixes it on a topic branch.
  7. 3. Bob creates a pull request to merge the branch back into master, creating
  8. a new issue on the project for the pull request.
  9. 4. Alice only gets notified of an update to issue #123 by way of a mention in
  10. the pull request, and now has to deal with tracking the status of the issue fix
  11. across two separate issues.
  12.  
  13. What should happen in steps 3 and 4 is:
  14.  
  15. 3. Bob creates a pull request to merge the branch back into master, tying that
  16. pull request back to the original issue that motivated it, #123, and --
  17. crucially -- not creating a separate issue for the pull request.
  18. 4. Alice gets notified of an update to the issue because the issue itself was
  19. directly updated. She can track the entire issue -- creation through fix -- in
  20. one spot.
  21.  
  22. While I recognize that you can simply reference the original issue #123 in the
  23. pull request, doing so still causes an issue to be created for the pull request
  24. itself (except in one corner case discussed below) which is one more issue than
  25. is needed in many cases. It's probably not as simple
  26. as simply tying back to any issue mentioned (since there may be many, or they
  27. may be on a separate repo entirely), there should be a way to accommodate this.
  28. The flow of issue -> topic branch -> pull request -> issue resolution is very
  29. common, and could be better served with the ability to tie the PR back to the
  30. original issue.
  31.  
  32. As an additional source of (perhaps not intentional) confusion, if I happen to
  33. 'fix #123' in a commit message on the branch, then a pull request for that
  34. branch *does* get tied back to (now closed) issue #123. Interestingly this
  35. doesn't seem to happen if I mention 'fix #123' in the pull request itself.
  36.  
  37. I can see two fixes to this:
  38.  
  39. 1. Provide a mechanism in the UI to tie a pull request to a specific issue at
  40. creation time (this is what hub does)
  41.  
  42. 2. Provide a different mention type within commit messages (and also within the
  43. creation message for the PR itself) saying what issue this ties back to.
  44. Something like 'sources #123' or 'references #123' or something.
Add Comment
Please, Sign In to add comment