Ascend Portfolio shortcode

function kad_portfolio_shortcode_new_function( $atts, $content) {
    extract(shortcode_atts(array(
        'orderby'       => 'menu_order',
        'cat'           => '',
        'order'         => '',
        'offset'        => null,
        'id'            => (rand(10,1000)),
        'columns'       => '4',
        'lightbox'      => 'false',
        'height'        => '',
        'width'         => '',
        'isostyle'      => 'masonry',
        'layout'        => 'normal',
        'filter'        => 'false',
        'excerpt'       => 'false',
        'showtypes'     => 'true',
        'items'         => '4'
), $atts));
    if(!empty($order) ) {
        $order = $order;
    } else if($orderby == 'menu_order' || $orderby == "title") {
        $order = 'ASC';
    } else {
        $order = 'DESC';
    }
    if(empty($cat)) {
        $cat = '';
        $portfolio_cat_ID = '';
    } else {
        $portfolio_cat = get_term_by ('slug',$cat,'portfolio-type' );
        $portfolio_cat_ID = $portfolio_cat -> term_id;
    }
    if ($columns == '2') {
        $itemsize = 'tcol-md-6 tcol-sm-6 tcol-xs-12 tcol-ss-12';
        $slidewidth = 560;
        $slideheight = 560;
    } else if ($columns == '1') {
        $itemsize = 'tcol-md-12 tcol-sm-12 tcol-xs-12 tcol-ss-12';
        $slidewidth = 560;
        $slideheight = 560;
    } else if ($columns == '3'){
        $itemsize = 'tcol-md-4 tcol-sm-4 tcol-xs-6 tcol-ss-12';
        $slidewidth = 366;
        $slideheight = 366;
    } else if ($columns == '6'){
        $itemsize = 'tcol-md-2 tcol-sm-3 tcol-xs-4 tcol-ss-6';
        $slidewidth = 240;
        $slideheight = 240;
    } else if ($columns == '5'){
        $itemsize = 'tcol-md-25 tcol-sm-3 tcol-xs-4 tcol-ss-6';
        $slidewidth = 240;
        $slideheight = 240;
    } else {
        $itemsize = 'tcol-md-3 tcol-sm-4 tcol-xs-6 tcol-ss-12';
        $slidewidth = 270;
        $slideheight = 270;
    }
    if(!empty($height) && $height == 'none') {
        $slideheight = null;
    } else if(!empty($height)) {
        $slideheight = $height;
    }
    if(!empty($width)){
        $slidewidth = $width;
    }
    if(!empty($layout) && $layout == 'mosaic'){
        if ($columns == '3') {
                      $itemsize_normal = 'tcol-lg-4 tcol-md-4 tcol-sm-4 tcol-xs-6 tcol-ss-12 mosiac_item_normal'; $ximgsize_normal = 400;$yimgsize_normal = 400;
                      $itemsize_wide = 'tcol-lg-8 tcol-md-8 tcol-sm-8 tcol-xs-12 tcol-ss-12 mosiac_item_wide'; $ximgsize_wide = 800;$yimgsize_wide = 400; $wide_string = '0,8,16,22,30';
                      $itemsize_tall = 'tcol-lg-4 tcol-md-4 tcol-sm-4 tcol-xs-6 tcol-ss-12 mosiac_item_tall'; $ximgsize_tall = 400;$yimgsize_tall = 800; $tall_string = '5,12,14,27';
                      $itemsize_large = 'tcol-lg-8 tcol-md-8 tcol-sm-8 tcol-xs-12 tcol-ss-12 mosiac_item_large'; $ximgsize_large = 800;$yimgsize_large = 800; $large_string = '3,9,19,24';
            } else {
                      $itemsize_normal = 'tcol-lg-3 tcol-md-3 tcol-sm-3 tcol-xs-6 tcol-ss-12 mosiac_item_normal'; $ximgsize_normal = 300;$yimgsize_normal = 300;
                      $itemsize_wide = 'tcol-lg-6 tcol-md-6 tcol-sm-6 tcol-xs-12 tcol-ss-12 mosiac_item_wide'; $ximgsize_wide = 600;$yimgsize_wide = 300; $wide_string = '0,9,16,21,30';
                      $itemsize_tall = 'tcol-lg-3 tcol-md-3 tcol-sm-3 tcol-xs-6 tcol-ss-12 mosiac_item_tall'; $ximgsize_tall = 300;$yimgsize_tall = 600; $tall_string = '4,12,18,25';
                      $itemsize_large = 'tcol-lg-6 tcol-md-6 tcol-sm-6 tcol-xs-12 tcol-ss-12 mosiac_item_large'; $ximgsize_large = 600;$yimgsize_large = 600; $large_string = '1,10,17,22';
            }
                    global $kt_portfolio_loop_mosaic;
                    $kt_portfolio_loop_mosaic = array(
                    'itemsize_normal' => $itemsize_normal,
                    'ximgsize_normal' => $ximgsize_normal,
                    'yimgsize_normal' => $yimgsize_normal,
                    'itemsize_wide' => $itemsize_wide,
                    'ximgsize_wide' => $ximgsize_wide,
                    'yimgsize_wide' => $yimgsize_wide,
                    'wide_string' => $wide_string,
                    'itemsize_tall' => $itemsize_tall,
                    'ximgsize_tall' => $ximgsize_tall,
                    'yimgsize_tall' => $yimgsize_tall,
                    'tall_string' => $tall_string,
                    'itemsize_large' => $itemsize_large,
                    'ximgsize_large' => $ximgsize_large,
                    'yimgsize_large' => $yimgsize_large,
                    'large_string' => $large_string,
                    'item_count' => 0,
                    );
    }
    global $ascend_premium, $kt_portfolio_loop;
    if(isset($ascend_premium['ascend_animate_in']) && $ascend_premium['ascend_animate_in'] == 1) {
        $animate = 1;
    } else {
        $animate = 0;
    }
                 $kt_portfolio_loop = array(
                    'lightbox' => $lightbox,
                    'showexcerpt' => $excerpt,
                    'showtypes' => $showtypes,
                    'slidewidth' => apply_filters('kt_portfolio_grid_image_width', $slidewidth),
                    'slideheight' => apply_filters('kt_portfolio_grid_image_height', $slideheight),
                    );
ob_start(); ?>
    <?php if ($filter == "true") { ?>
        <section id="options" class="clearfix">
            <?php global $ascend_premium;
            if(!empty($ascend_premium['filter_all_text'])) {
                $alltext = $ascend_premium['filter_all_text'];
            } else {
                $alltext = __('All', 'ascend');
            }
            if(!empty($ascend_premium['portfolio_filter_text'])) {
                $portfoliofiltertext = $ascend_premium['portfolio_filter_text'];
            } else {
                $portfoliofiltertext = __('Filter Projects', 'ascend');
            }
            $termtypes = array( 'child_of' => $portfolio_cat_ID,);
            $categories= get_terms('portfolio-type', $termtypes);
            $count = count($categories);

                        echo '<a class="filter-trigger headerfont" data-toggle="collapse" data-target=".filter-collapse"><i class="icon-tags"></i> '.$portfoliofiltertext.'</a>';
                        echo '<ul id="filters" class="clearfix option-set filter-collapse">';
                        echo '<li class="postclass"><a href="#" data-filter="*" title="All" class="selected"><h5>'.$alltext.'</h5><div class="arrow-up"></div></a></li>';
                        if ( $count > 0 ){
                            foreach ($categories as $category){
                                $termname = strtolower($category->slug);
                                $termname = preg_replace("/[^a-zA-Z 0-9]+/", " ", $termname);
                                $termname = str_replace(' ', '-', $termname);
                                    echo '<li class="postclass"><a href="#" data-filter=".'.esc_attr($termname).'" title="" rel="'.esc_attr($termname).'"><h5>'.$category->name.'</h5><div class="arrow-up"></div></a></li>';
                                }
                        }
                        echo "</ul>"; ?>
            </section>
            <?php }

            if(!empty($layout) && $layout == 'mosaic'){ ?>
                 <div class="kad-mosaic-portfolio-wrapper">
                 <div id="portfoliowrapper" class="init-mosaic-isotope reinit-isotope rowtight" data-fade-in="<?php echo esc_attr($animate);?>" data-iso-selector=".p-item" data-iso-style="packery" data-iso-filter="true">
            <?php } else { ?>
                <div class="home-portfolio kad-portfolio-wrapper">
                        <div id="portfoliowrapper-<?php echo esc_attr($id);?>" class="rowtight init-isotope-intrinsic reinit-isotope" data-fade-in="<?php echo esc_attr($animate);?>" data-iso-selector=".p-item" data-iso-style="<?php echo esc_attr($isostyle);?>" data-iso-filter="true">
            <?php }
                $wp_query = null;
                  $wp_query = new WP_Query();
                      if ( $orderby == 'date-title' ) {
                          $wp_query->query(array(
                            'orderby'           => array( 'date' => 'DESC', 'title' => 'ASC' ),
                            'offset'            => $offset,
                            'post_type'         => 'portfolio',
                            'portfolio-type'    => $cat,
                            'posts_per_page'    => $items
                            )
                          );
                      } else {
                      $wp_query->query(array(
                        'orderby'           => $orderby,
                        'order'             => $order,
                        'offset'            => $offset,
                        'post_type'         => 'portfolio',
                        'portfolio-type'    => $cat,
                        'posts_per_page'    => $items
                        )
                      );
                      }
                    if ( $wp_query ) : while ( $wp_query->have_posts() ) : $wp_query->the_post();

                    if(!empty($layout) && $layout == 'mosaic'){
                                do_action('kadence_portfolio_loop_start');
                                    get_template_part('templates/content', 'loop-portfolio-mosaic');
                                  do_action('kadence_portfolio_loop_end');

                    } else {

                        global $post; $terms = get_the_terms( $post->ID, 'portfolio-type' );
                        if ( $terms && ! is_wp_error( $terms ) ) :
                            $links = array();
                                foreach ( $terms as $term ) { $links[] = $term->slug;}
                            $links = preg_replace("/[^a-zA-Z 0-9]+/", " ", $links);
                            $links = str_replace(' ', '-', $links);
                            $tax = join( " ", $links );
                        else :
                            $tax = '';
                        endif;
                        ?>

                        <div class="<?php echo esc_attr($itemsize);?> <?php echo strtolower($tax); ?> all p-item">
                            <?php do_action('kadence_portfolio_loop_start');
                                get_template_part('templates/content', 'loop-portfolio');
                                do_action( 'kadence_portfolio_loop_end' );
                            ?>
                        </div>
            <?php }

            endwhile; else: ?>
                <li class="error-not-found"><?php _e('Sorry, no portfolio entries found.', 'ascend');?></li>
            <?php endif; ?>
            </div> <!-- portfoliowrapper -->
            <?php $wp_query = null; wp_reset_query(); ?>
        </div><!-- /.home-portfolio -->

    <?php  $output = ob_get_contents();
        ob_end_clean();
        wp_reset_postdata();
    return $output;
}

add_action('wp', 'remove_ascend_portfolio_shortcode');

function remove_ascend_portfolio_shortcode(){
    remove_shortcode('portfolio_posts');
    add_shortcode('portfolio_posts', 'kad_portfolio_shortcode_new_function');
}