PVS-StudioWarnings

PVS-Studio warning V502 for FCEUX

Nov 10th, 2014
140
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.66 KB | None | 0 0
  1. static BOOL CALLBACK MemWatchCallB(....)
  2. {
  3.   ...
  4.   EnableMenuItem(memwmenu, MEMW_FILE_SAVE,
  5.     MF_BYCOMMAND | fileChanged ? MF_ENABLED:MF_GRAYED);
  6.   ...
  7. }
  8.  
  9. It works because of sheer luck, since #define MF_BYCOMMAND 0x00000000L.
  10.  
  11. This suspicious code was found in FCEUX project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V502 Perhaps the '?:' operator works in a different way than it was expected. The '?:' operator has a lower priority than the '|' operator. fceux memwatch.cpp 711
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment