PVS-StudioWarnings

PVS-Studio warning V519 for MTASA

Nov 26th, 2014
163
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.82 KB | None | 0 0
  1. void CPacketHandler::Packet_ServerDisconnected (....)
  2. {
  3.   ....
  4.   case ePlayerDisconnectType::BANNED_IP:
  5.     strReason = _("Disconnected: You are banned.\nReason: %s");
  6.     strErrorCode = _E("CD33");
  7.     bitStream.ReadString ( strDuration );
  8.   case ePlayerDisconnectType::BANNED_ACCOUNT:
  9.     strReason =
  10.      _("Disconnected: Account is banned.\nReason: %s");
  11.     strErrorCode = _E("CD34");
  12.     break;
  13.   ....
  14. }
  15.  
  16. This suspicious code was found in MTASA project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V519 The 'strReason' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 558, 561. cpackethandler.cpp 561
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment