PVS-StudioWarnings

PVS-Studio warning V564 for NSS

Nov 10th, 2014
157
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.71 KB | None | 0 0
  1. PRBool SEC_ASN1IsTemplateSimple(
  2.   const SEC_ASN1Template *theTemplate)
  3. {
  4.   ...
  5.   if (!theTemplate->kind & SEC_ASN1_CHOICE) {
  6.     return PR_FALSE; /* no choice means not simple */
  7.   }
  8.   ...
  9. }
  10.  
  11. This is what should have been written here: if (!(theTemplate->kind & SEC_ASN1_CHOICE)) {
  12.  
  13. This suspicious code was found in NSS project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V564 The '&' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '&&' operator. nss secasn1u.c 121
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment