Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- - neuer pr -> DONE
- - konfigurierbar wenn < x dann direkt whitelist
- - change method get to post für state changes -> DONE
- - review showButtons(Job job) -> DONE
- - changeSiteStatus kein get (POST), also review -> DONE
- - rev 1 + 2 nach job schreiben -> NOPE!!
- - JOB_RESPONSES_V must get reviewers
- - jobdetail: show reviews
- - gesamte history für job: job+site > review
- - BUG: done after rev 1 ?? -> AS DESIGNED
- - TODO Set reviewer2 for job
- - getShowButtons: inconsistent logic when sent back to rev 1
- - Wenn auto whitelist dann möglichkeit das zu overriden
- ==============================================================================================
- INCONSISTENCY:
- - When rev2 sets another state than rev1, the job is back to rev1, Problem:
- - getShowButtons will always return true even if rev1 = rev2 -> TODO remove state check, ALWAYS check latest rev
- - Is the latest rev always the other rev?? -> CONFIRNED (1. rev1 sets W, 2. rev2 set B -> STATE = WAITING_FOR_REV1, latest = rev2)
- - Edge cases??: should be ok, problem is linear
- ,
- JOB_REVIEWER_ONE AS DRV_JOB_REVIEWER_ONE,
- JOB_REVIEWER_TWO AS DRV_JOB_REVIEWER_TWO
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement