Advertisement
markoczy

SOF-TODO

Sep 28th, 2020
144
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 1.16 KB | None | 0 0
  1. - neuer pr -> DONE
  2.  
  3. - konfigurierbar wenn < x dann direkt whitelist
  4. - change method get to post für state changes -> DONE
  5. - review showButtons(Job job) -> DONE
  6. - changeSiteStatus kein get (POST), also review -> DONE
  7. - rev 1 + 2 nach job schreiben -> NOPE!!
  8. - JOB_RESPONSES_V must get reviewers
  9. - jobdetail: show reviews
  10. - gesamte history für job: job+site > review
  11.  
  12.  
  13.  
  14. - BUG: done after rev 1 ?? -> AS DESIGNED
  15.  
  16.  
  17. - TODO Set reviewer2 for job
  18.  
  19. - getShowButtons: inconsistent logic when sent back to rev 1
  20.  
  21. - Wenn auto whitelist dann möglichkeit das zu overriden
  22.  
  23. ==============================================================================================
  24.  
  25. INCONSISTENCY:
  26.  
  27. - When rev2 sets another state than rev1, the job is back to rev1, Problem:
  28. - getShowButtons will always return true even if rev1 = rev2 -> TODO remove state check, ALWAYS check latest rev
  29. - Is the latest rev always the other rev?? -> CONFIRNED (1. rev1 sets W, 2. rev2 set B -> STATE = WAITING_FOR_REV1, latest = rev2)
  30. - Edge cases??: should be ok, problem is linear
  31.  
  32.  
  33. ,
  34. JOB_REVIEWER_ONE AS DRV_JOB_REVIEWER_ONE,
  35. JOB_REVIEWER_TWO AS DRV_JOB_REVIEWER_TWO
  36.  
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement