PVS-StudioWarnings

PVS-Studio warning V547 for TPP

Nov 20th, 2014
180
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.68 KB | None | 0 0
  1. void SpectraSTReplicates::aggregateStats(....)
  2. {
  3.   ...
  4.   unsigned int numAssignedPeaks =
  5.     (*r)->entry->getPeakList()->getNumAssignedPeaks();
  6.   if (numAssignedPeaks >= 0)
  7.   {
  8.     sumFracAssigned +=
  9.       (double)numAssignedPeaks / (double)numPeaks;
  10.     numAnnotated++;
  11.   }
  12.   ...
  13. }
  14.  
  15. This suspicious code was found in TPP project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V547 Expression 'numAssignedPeaks >= 0' is always true. Unsigned type value is always >= 0. tpplib spectrastreplicates.cpp 642
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment