PVS-StudioWarnings

PVS-Studio warning V501 for Audacity

Nov 20th, 2014
146
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. sampleCount VoiceKey::OnBackward (....) {
  2.   ...
  3.   int atrend = sgn(buffer[samplesleft - 2]-
  4.                    buffer[samplesleft - 1]);
  5.   int ztrend = sgn(buffer[samplesleft - WindowSizeInt-2]-
  6.                    buffer[samplesleft - WindowSizeInt-2]);
  7.   ...
  8. }
  9.  
  10. A Copy-Paste error. In the last line 1 should be subtracted instead of 2.
  11.  
  12. This suspicious code was found in Audacity project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V501 There are identical sub-expressions to the left and to the right of the '-' operator. Audacity voicekey.cpp 304
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment