PVS-StudioWarnings

PVS-Studio warning V518 for FCEUX

Nov 18th, 2014
160
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.59 KB | None | 0 0
  1. int FCEUI_SetCheat(....)
  2. {
  3.   ...
  4.   if((t=(char *)realloc(next->name,strlen(name+1))))
  5.   ...
  6. }
  7.  
  8. This is what should have been written here: strlen(name)+1.
  9.  
  10. This suspicious code was found in FCEUX project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V518 The 'realloc' function allocates strange amount of memory calculated by 'strlen(expr)'. Perhaps the correct variant is 'strlen(expr) + 1'. fceux cheat.cpp 609
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment