API tools faq
paste
Advertisement
Guest User

review.txt

a guest
May 26th, 2017
612
0
Never
Add comment
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 8.26 KB | None | 0 0
raw download clone embed print report
  1.  
  2. This is a review *template*. Besides handling the [ ]-marked tests you are
  3. also supposed to fix the template before pasting into bugzilla:
  4. - Add issues you find to the list of issues on top. If there isn't such
  5. a list, create one.
  6. - Add your own remarks to the template checks.
  7. - Add new lines marked [!] or [?] when you discover new things not
  8. listed by fedora-review.
  9. - Change or remove any text in the template which is plain wrong. In this
  10. case you could also file a bug against fedora-review
  11. - Remove the "[ ] Manual check required", you will not have any such lines
  12. in what you paste.
  13. - Remove attachments which you deem not really useful (the rpmlint
  14. ones are mandatory, though)
  15. - Remove this text
  16.  
  17.  
  18.  
  19. Package Review
  20. ==============
  21.  
  22. Legend:
  23. [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
  24. [ ] = Manual review needed
  25.  
  26.  
  27. Issues:
  28. =======
  29. - Package installs properly.
  30. Note: Installation errors (see attachment)
  31. See: https://fedoraproject.org/wiki/Packaging:Guidelines
  32.  
  33.  
  34. ===== MUST items =====
  35.  
  36. Generic:
  37. [ ]: Package is licensed with an open-source compatible license and meets
  38. other legal requirements as defined in the legal section of Packaging
  39. Guidelines.
  40. [ ]: License field in the package spec file matches the actual license.
  41. Note: Checking patched sources after %prep for licenses. Licenses
  42. found: "Unknown or generated". 3864 files have unknown license.
  43. Detailed output of licensecheck in /home/thanos/review/review-vertex-
  44. theme/licensecheck.txt
  45. [ ]: Package contains no bundled libraries without FPC exception.
  46. [ ]: Changelog in prescribed format.
  47. [ ]: Sources contain only permissible code or content.
  48. [ ]: Package contains desktop file if it is a GUI application.
  49. [ ]: Development files must be in a -devel package
  50. [ ]: Package uses nothing in %doc for runtime.
  51. [ ]: Package consistently uses macros (instead of hard-coded directory
  52. names).
  53. [ ]: Package is named according to the Package Naming Guidelines.
  54. [ ]: Package does not generate any conflict.
  55. [ ]: Package obeys FHS, except libexecdir and /usr/target.
  56. [ ]: If the package is a rename of another package, proper Obsoletes and
  57. Provides are present.
  58. [ ]: Requires correct, justified where necessary.
  59. [ ]: Spec file is legible and written in American English.
  60. [ ]: Package contains systemd file(s) if in need.
  61. [ ]: Package is not known to require an ExcludeArch tag.
  62. [ ]: Large documentation must go in a -doc subpackage. Large could be size
  63. (~1MB) or number of files.
  64. Note: Documentation size is 10240 bytes in 1 files.
  65. [ ]: Package complies to the Packaging Guidelines
  66. [x]: Package successfully compiles and builds into binary rpms on at least
  67. one supported primary architecture.
  68. [x]: Rpmlint is run on all rpms the build produces.
  69. Note: No rpmlint messages.
  70. [x]: If (and only if) the source package includes the text of the
  71. license(s) in its own file, then that file, containing the text of the
  72. license(s) for the package is included in %license.
  73. [x]: Package requires other packages for directories it uses.
  74. [x]: Package must own all directories that it creates.
  75. [x]: Package does not own files or directories owned by other packages.
  76. [x]: All build dependencies are listed in BuildRequires, except for any
  77. that are listed in the exceptions section of Packaging Guidelines.
  78. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
  79. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
  80. beginning of %install.
  81. [x]: Macros in Summary, %description expandable at SRPM build time.
  82. [x]: Dist tag is present.
  83. [x]: Package does not contain duplicates in %files.
  84. [x]: Permissions on files are set properly.
  85. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
  86. work.
  87. [x]: Package is named using only allowed ASCII characters.
  88. [x]: Package does not use a name that already exists.
  89. [x]: Package is not relocatable.
  90. [x]: Sources used to build the package match the upstream source, as
  91. provided in the spec URL.
  92. [x]: Spec file name must match the spec package %{name}, in the format
  93. %{name}.spec.
  94. [x]: File names are valid UTF-8.
  95. [x]: Packages must not store files under /srv, /opt or /usr/local
  96.  
  97. ===== SHOULD items =====
  98.  
  99. Generic:
  100. [ ]: If the source package does not include license text(s) as a separate
  101. file from upstream, the packager SHOULD query upstream to include it.
  102. [ ]: Final provides and requires are sane (see attachments).
  103. [ ]: Package functions as described.
  104. [ ]: Latest version is packaged.
  105. [ ]: Package does not include license text files separate from upstream.
  106. [ ]: Description and summary sections in the package spec file contains
  107. translations for supported Non-English languages, if available.
  108. [ ]: Package should compile and build into binary rpms on all supported
  109. architectures.
  110. [ ]: %check is present and all tests pass.
  111. [ ]: Packages should try to preserve timestamps of original installed
  112. files.
  113. [x]: Reviewer should test that the package builds in mock.
  114. [x]: Buildroot is not present
  115. [x]: Package has no %clean section with rm -rf %{buildroot} (or
  116. $RPM_BUILD_ROOT)
  117. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
  118. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
  119. [x]: Sources can be downloaded from URI in Source: tag
  120. [x]: SourceX is a working URL.
  121. [x]: Spec use %global instead of %define unless justified.
  122.  
  123. ===== EXTRA items =====
  124.  
  125. Generic:
  126. [!]: Rpmlint is run on all installed packages.
  127. Note: Mock build failed
  128. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
  129. [x]: Package should not use obsolete m4 macros
  130. [x]: Spec file according to URL is the same as in SRPM.
  131.  
  132.  
  133. Installation errors
  134. -------------------
  135. INFO: mock.py version 1.4.1 starting (python version = 3.6.1)...
  136. Start: init plugins
  137. INFO: selinux disabled
  138. Finish: init plugins
  139. Start: init plugins
  140. INFO: selinux disabled
  141. Finish: init plugins
  142. Start: run
  143. Start: chroot init
  144. INFO: calling preinit hooks
  145. INFO: enabled root cache
  146. INFO: enabled dnf cache
  147. Start: cleaning dnf metadata
  148. Finish: cleaning dnf metadata
  149. INFO: enabled HW Info plugin
  150. Mock Version: 1.4.1
  151. INFO: Mock Version: 1.4.1
  152. Finish: chroot init
  153. Start: chroot init
  154. INFO: calling preinit hooks
  155. INFO: enabled root cache
  156. INFO: enabled dnf cache
  157. Start: cleaning dnf metadata
  158. Finish: cleaning dnf metadata
  159. INFO: enabled HW Info plugin
  160. Mock Version: 1.4.1
  161. INFO: Mock Version: 1.4.1
  162. Finish: chroot init
  163. INFO: installing package(s): /home/thanos/review/review-vertex-theme/results/vertex-theme-20170128-3.fc27.noarch.rpm
  164. ERROR: Command failed:
  165. # /usr/bin/systemd-nspawn -q -M 75c980c4ba3a49e18922b335265646e1 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=en_US.utf8 --setenv=LC_MESSAGES=C /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 27 --disableplugin=local --setopt=deltarpm=false install /home/thanos/review/review-vertex-theme/results/vertex-theme-20170128-3.fc27.noarch.rpm
  166.  
  167.  
  168.  
  169. Rpmlint
  170. -------
  171. Checking: vertex-theme-20170128-3.fc27.noarch.rpm
  172. vertex-theme-20170128-3.fc27.src.rpm
  173. 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
  174.  
  175.  
  176.  
  177.  
  178. Requires
  179. --------
  180. vertex-theme (rpmlib, GLIBC filtered):
  181. filesystem
  182. gnome-themes-standard
  183. gtk-murrine-engine
  184.  
  185.  
  186.  
  187. Provides
  188. --------
  189. vertex-theme:
  190. vertex-theme
  191.  
  192.  
  193.  
  194. Source checksums
  195. ----------------
  196. https://github.com/horst3180/vertex-theme/archive/20170128.tar.gz :
  197. CHECKSUM(SHA256) this package : 1540657ff247bcdb9c49a740e4ddf305aecd4f3bebc93ca566fe74d319b7a620
  198. CHECKSUM(SHA256) upstream package : 1540657ff247bcdb9c49a740e4ddf305aecd4f3bebc93ca566fe74d319b7a620
  199.  
  200.  
  201. Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
  202. Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -n vertex-theme
  203. Buildroot used: fedora-rawhide-x86_64
  204. Active plugins: Generic, Shell-api
  205. Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
  206. Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement
Public Pastes
Advertisement
We use cookies for various purposes including analytics. By continuing to use Pastebin, you agree to our use of cookies as described in the Cookies Policy.  OK, I Understand
Not a member of Pastebin yet?
Sign Up, it unlocks many cool features!