Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- # git clone https://gitlab.com/procps-ng/procps.git
- # cd procps
- # git log --author=warner
- commit b4923fa7450824f9ed85fe5ce0d7a0d721329304
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Aug 6 08:43:48 2015 -0500
- miscellaneous: a final cleanup prior to release 3.3.11
- This patch just eliminates some eol whitespace, adds a
- missing eof newline and contributes yet one additional
- entry to the NEWS summary regarding saved top rcfiles.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 3da298c1d6b9c82e99e7025162657a8b5e2ce551
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Aug 3 00:00:00 2015 -0500
- top: fix unlikely edge case wherein all fields are off
- While testing a newlib interface for pids acquisitions
- I encountered some unexpected results if an idiot user
- (me) turns off all displayable fields. So, this commit
- ensures that the PID field will be shown as a minimum.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 8226ca983856d2d023dc52e5d56ec92552b5bf18
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jul 31 00:00:00 2015 -0500
- top: avoid an unnecessary conversion for 'USED' column
- When the USED column was introduced the proc_t.vm_swap
- & proc_t.resident values were added together. However,
- using 'resident' required an additional PROC_FILL flag
- not to mention extra conversion of pages to kibibytes.
- So now we'll use an already present vm_rss value which
- removes any special handling for top's derived column.
- And while we're at it we'll trade some more 'resident'
- field uses with that more immediately usable 'vm_rss'.
- Reference(s):
- commit 709785e20bd19dc28546d19c45bb7444a56f88b9
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 9ba65bad8ef1bb994f3edd45063878daa1beb78c
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Jul 27 00:00:00 2015 -0500
- top: miscellaneous accumulated tweaks to code/comments
- Jeeze, to correct spelling on one single word (incure)
- you had to go and align the entire comments paragraph?
- [ well, at least there's one other minor code change ]
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 9cc6ed10c87ac25ded3bcc1ad5c54d05d656d99e
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Jul 27 00:00:00 2015 -0500
- top: eliminate 'user' from the inspection view headers
- Since it's possible that euser name is not being shown
- or the horizontal position had been scrolled past that
- USER column, then part of those headers will be blank.
- So it doesn't make sense to try and show the USER that
- is associated with a process at all. Thus, this commit
- simply removes the 'user' provision from both headers.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit c07f6c5e6d6170ef3f2373b4d86988184c3235bf
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sun Jul 12 04:44:44 2015 -0500
- top: improve vertical scroll management for 'i' toggle
- When a user is taking advantage of the scroll features
- it is likely a scrolled vertical position is well past
- the first displayable task. That is especially true of
- top's forest view ('V') mode where those early systemd
- attached processes are generally not very interesting.
- As such, should the idle mode toggle ('i') be employed
- a distorted display is almost guaranteed because tasks
- that have used some cpu, and thus should be displayed,
- have already been skipped by virtue of their position.
- So this patch temporarily nullifies vertical scrolling
- during the period when idle tasks are not being shown.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 9e85c147b2ac4eb4177d87bab541f00f958e5a8d
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 20 00:00:00 2015 -0500
- build-sys: tweak to prevent dirty tree with every make
- Please let's stop the nls translation insanity. With a
- one time push we can eliminate the dirty tree syndrome
- which surfaces with every local build. Later, before a
- release, the translations can be updated in final form
- then pushed just 1 more time to the gitlab repository.
- I'm tired of having to always re-issue this request in
- order to circumvent the problem and thus prevent a too
- broad commit (not to mention some nasty side effects).
- [ bash$ git update-index --assume-unchanged po/??.po ]
- Reference(s):
- http://www.freelists.org/post/procps/procpsng-translations
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 88fe45ef6815d7d06cc7efba70351fdc80277996
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 20 00:00:00 2015 -0500
- top: sacrifice a redundant procps_linux_version() call
- With the commit referenced below, the linux version is
- no longer available via an external variable. So we'll
- eliminate the extra superficial function call employed
- at program end as part of a debugging (only) o/p spew.
- [ the user will soon be returned to the command line ]
- [ & he/she can run their own 'uname -r' if in doubt! ]
- Reference(s):
- commit 56d9d5e7e701e71646679b2b8cefa9239ee59592
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 4129c758ac2eae553450bd1875942677618ff2fa
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jun 19 08:41:51 2015 -0500
- miscellaneous: remove some trailing whitespace buildup
- wish folks (craig) would use these in their .gitconfig
- [core]
- whitespace = trailing-space, space-before-tab, blank-at-eof
- [apply]
- whitespace = warn
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit ad0a0fc138e7f9520aac07966f2dd7830813497d
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jun 19 08:34:12 2015 -0500
- build-sys: fix oversight for a newly added header file
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 3600f652e83b5b9e084e0a9ffecaeae4115d4fab
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jun 18 00:00:00 2015 -0500
- documentation: fix man pages due to refactor for wchan
- This patch will bring three of our man pages into line
- with the recent refactor of the libprocps wchan logic.
- [ and also eliminates more damn eol whitespace which ]
- [ snuck in our repo with the commit referenced below ]
- Reference(s):
- http://www.freelists.org/post/procps/WCHAN,11
- commit cf4788c28dba784a09c8b036a56fffa49da584e7
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 93666da62c3ef333a546f8a208c50e21d01107cd
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jun 18 00:00:00 2015 -0500
- top: adapt to a simplified library interface for wchan
- This patch was made necessary by those library changes
- in support of recently revised/simplified wchan logic.
- Reference(s):
- http://www.freelists.org/post/procps/WCHAN,11
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit caeebdc71f4def59af908e4afcf9b63e781fe4c6
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jun 18 00:00:00 2015 -0500
- ps: exploit the simplified library interface for wchan
- This patch was made necessary by those library changes
- in support of recently revised/simplified wchan logic.
- In addition, this commit eliminates a broken alternate
- 'namelist' provision which was intended to allow users
- to specify a System.map file to be used in translating
- addresses into function names. But, the real effect of
- the now defunct 'N' and '-n' options was to indirectly
- force addresses (not names) to be displayed since such
- user named map files could not be successfully parsed.
- Besides when the required FRAME_POINTER kconfig option
- is absent there is no address to translate and when it
- is present /proc/PID/wchan is already translated. Thus
- an alternate mapping is unnecessary and inappropriate.
- [ we'll forgive POSIX for documenting '-n namelist' ]
- Reference(s):
- http://www.freelists.org/post/procps/WCHAN,11
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 6b8dc5511fb9780806c3e8b97e5514ec30c2f514
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jun 18 00:00:00 2015 -0500
- library: refactor and rely on modern kernels for wchan
- Several Debian based distributions were recently found
- to have omitted a kernel configuration option that had
- the effect of rendering /proc/#/stat and /proc/#/wchan
- useless for providing any 'sleeping in function' info.
- That problem also prompted a reevaluation of the whole
- approach to wchan matters which had grown increasingly
- complex as our library evolved over the last 13 years.
- The net result was a decision to rely on /proc/#/wchan
- which arrived along with the 2.5 kernel. This then let
- us vastly simplify the internal code plus the external
- interface which will benefit both the top and ps pgms.
- Reference(s):
- http://www.freelists.org/post/procps/WCHAN,11
- https://lkml.org/lkml/2008/11/6/12
- https://bugs.debian.org/711592
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 932f54b19d6b53d2dc804b291293052e7876fbda
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Jun 15 00:00:00 2015 -0500
- top: correct an alphabetic field error in man document
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 69580f7d98debb5df4b2050d30a1b027f6836838
- Author: Jim Warner <james.warner@comcast.net>
- Date: Tue May 12 03:00:00 2015 -0500
- build-sys: do not distribute the aging README.top file
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 65773719196a5fa0d2aadf984821f256cc0ea275
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 -0500
- ps: update man document to support LXC container names
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit f9e27afeb2ca28292223ab17395a546529d9704f
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 -0500
- ps: add code to exploit the new library LXC containers
- Reference(s):
- https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1424253
- https://bugs.launchpad.net/ubuntu/+source/procps/+bug/1424253
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit d8aee1a809fdb4764432ed47f69e9f4bf4ce6778
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 -0500
- top: update man document to support the LXC containers
- [ in addition to the primary 'lxc' business, i found ]
- [ numerous apostrophes used instead of that back-tic ]
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 2ba7aa8b7d4e1731044844589f736c5625a0b15e
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 -0500
- top: add support exploiting new library LXC containers
- Reference(s):
- https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1424253
- https://bugs.launchpad.net/ubuntu/+source/procps/+bug/1424253
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 0557504f9cb84987f9d9038755404be017bdb7d1
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 -0500
- library: add support for displaying LXC container name
- This commit adds a lxc container name to every proc_t.
- If a process is not running in a container, then a '-'
- will be provided, making such a field always sortable.
- Unlike other proc_t character pointers, lxc containers
- will find many duplicate shared values. So rather than
- strdup 'em (with a later free required upon reuse), we
- try to keep track of those already seen and share that
- address among all tasks running within each container.
- We rely on the lines in the task's cgroup subdirectory
- which may initially seem somewhat unsophisticated. But
- the lxc library itself uses a similar approach when it
- is called to list active containers. In that case, the
- /proc/net/unix directory is parsed for the '/lxc' eye-
- catcher, with potential complications from hashed path
- and names that are too long (something we don't face).
- [ too bad docker abandoned lxc - our commit won't do ]
- [ anything for the users of those kind of containers ]
- Reference(s):
- https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1424253
- https://bugs.launchpad.net/ubuntu/+source/procps/+bug/1424253
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 96bce4e11ee5bcbda8062169a75dea5561ef3618
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 13 00:00:00 2015 +0000
- library: address memory aberration with LXC containers
- Under a lxc container, the /proc/meminfo 'MemFree' and
- 'MemAvailable' amounts will be equal, unless memory is
- being limited via cgroups in which case 'MemAvailable'
- could exceed that for 'MemTotal'. And when a container
- has been nested, there exist additional memory quirks.
- A program might then display used or available amounts
- greater than total memory (assuming unsigned honored),
- or negative values (should a signed cast be employed).
- This anomaly primarily impacted the top and free pgms.
- Thus, two simple sanity checks have been introduced to
- avoid any illogical kb_main_available or kb_main_used.
- ( Busybox top & free also display anomalous although )
- ( different results when running in a lxc container. )
- Reference(s):
- https://bugzilla.redhat.com/show_bug.cgi?id=1153817
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit e107f5d63bbc52f5181d8356b344e854a16a2c04
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sun Feb 1 00:00:00 2015 -0600
- top: miscellaneous accumulated changes to program code
- This commit just tweaks top in the following respects:
- . for alphabetic integrity, change 'INSP_hdr...' names
- . eliminate the -Wsometimes-uninitialized warning that
- was found under OSX Yosemite (llvm 6.0/clang-600.0.56)
- . update program 'comments' reflecting copyright dates
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 8bcdd2145d6a3ab805536108b9a3dda3bf568f15
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sun Feb 1 00:00:00 2015 -0600
- top: miscellaneous accumulated changes to man document
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit da06b8fa5974ff8d651e45e55d52475c371054fe
- Author: Jim Warner <james.warner@comcast.net>
- Date: Tue Oct 28 00:00:00 2014 -0500
- top: tweak forest view protections for forking anomaly
- A recent commit eliminated the potential for a storage
- violation with forest view mode. It occurred when some
- program (erroneously?) created a lengthy forking loop.
- However, the associated commit message was misleading.
- The message implied that an unexpected order following
- a sort on start_time was the cause of storage overruns
- and a 'char' used to track nesting level only distorts
- the display when it goes negative. Actually, the truth
- is really just the opposite. Any start_time sort quirk
- causes no harm while that 'char' can yield corruption.
- Should some child end up sorted ahead of its parent by
- way of an extremely unlikely shared start_time the end
- result is such a child will be displayed unnested just
- like init or kthreadd along with all its own children.
- However, if nesting levels exceeded 255 (and became 0)
- a massive array overrun could be triggered when such a
- task and *all* its children were added to an array for
- the second time. Exactly how much storage was violated
- depended on the number of children that zeroed process
- had spawned (hinted at via either SIGSEGV or SIGABRT).
- The earlier commit limited nested levels to 100 so the
- root cause of the storage violation was already fixed.
- The potential for distorted nesting levels due to sort
- on start_time would seem to remain. But it's extremely
- unlikely that 2 tasks would share the same start_time.
- Even so, a new #define has been introduced which makes
- top impervious to the order of tasks such that a qsort
- is no longer necessary (providing an init/systemd task
- exists & was harvested as the first task by readproc).
- It can be utilized if distorted nesting ever becomes a
- real issue. But since there is a 5-10% performance hit
- with that, we'll continue using start_time as default.
- References(s):
- commit ce70017eb1927be51f73cbe0a0b4babcc502607e
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit ce70017eb1927be51f73cbe0a0b4babcc502607e
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Oct 23 00:00:00 2014 -0500
- top: provide some protection against forking anomalies
- This commit will eliminate a very nasty bug associated
- with top's forest view mode. It addresses a potential
- SIGSEGV/SIGABRT that was only encountered when another
- program (erroneously?) creates a lengthy forking loop.
- If the growing list of nested children is sufficiently
- fast such that proc_t start_time is duplicated between
- children then the sort upon which top relies might not
- produce the expected order. That, in turn, could cause
- the forest_adds function to initially miss some child.
- But that missed child would be caught by forest_create
- and eventually would cause our array boundary overrun.
- Such overrun occurs when some child of that originally
- *missed* child is found and a duplicate add attempted.
- In correcting this bug we'll also use this opportunity
- to prohibit a borrowed proc_t padding byte (char) from
- going negative. If the nesting level exceeded 127, the
- effect was an "unnesting" with the snprintf width then
- viewed as flag+width also yielding left justification.
- Henceforth, we'll limit nesting to 100 with subsequent
- children shown as " + ", not the usual " `- " prefix.
- References(s):
- https://bugzilla.redhat.com/show_bug.cgi?id=1153642
- http://www.freelists.org/post/procps/Bug-in-the-forrest-view,6
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit b0767bd391da2c868ccabe1f0213e1593f1e2eed
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sun Sep 28 00:00:00 2014 -0500
- top: ensure previously saved rcfile honored completely
- When startup defaults were changed users with existing
- rcfiles would likely find their previous configuration
- was not being honored in all respects. The disparities
- involved Graphs modes and Summary/Task memory scaling.
- This patch simply restores what was always intended as
- the proper behavior for previously saved config files.
- References(s):
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762928
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762947
- . new startup defaults
- commit 8ef6cd91fc5df6372a93bc4a37cbad34ead9654e
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 8adf4acc033e25dfa68edbf4a8b7fc44148cd370
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Aug 8 11:59:59 2014 -0500
- top: final tweak to recent changes for new graph modes
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit fd71717b9b760c988898f5eb0d1459f0b04cc739
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Aug 7 00:00:00 2014 -0500
- NEWS: add a few more for the release 3.3.10 change log
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit e92b692932b8313f335009758b60f67b5adaadc7
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Aug 7 00:00:00 2014 -0500
- top: swat a potential buglet affecting new graph modes
- This patch will cure a potential aberration associated
- with a terminal's size (SIGWINCH) and top's new graphs
- modes. The symptoms were a dangling tilde (~) plus the
- potential loss of a graph's right-most visual content.
- The condition was only apparent when a %Cpu approached
- 100% usage. Also the apparent loss of content affected
- the 'block' graph only. With 'bar' graphs, that affect
- became the loss of proper right-most bar graph colors.
- The cause was determined to be a combination of: 1) an
- unnecessary snprintf precision specification; and 2) a
- rounding quirk for any graphs which displayed distinct
- types of information (as for user/syst, used/unavail).
- These could then combine to produce an extra bar/block
- which, in turn, resulted in the truncation of a pseudo
- termcap attribute used by the show_special() function.
- What was originally interpreted as an intractable race
- condition turns out to be just a self inflicted wound.
- Reference(s):
- http://www.freelists.org/post/procps/top-Possible-bug-in-the-graphs,1
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit bcbc3c5a029b8936c72063bf1175b42a97f184f2
- Author: Jim Warner <james.warner@comcast.net>
- Date: Wed Aug 6 00:00:00 2014 -0500
- misc: result after checking all files for misspellings
- Reference(s):
- https://github.com/lyda/misspell-check.git
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 5380ef902297ad93b4691ed321cb85a727591505
- Author: Jim Warner <james.warner@comcast.net>
- Date: Wed Jul 30 00:00:00 2014 -0500
- top: adapt global memory support to new library format
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit c437faf8d32c7cf5d2b0eefb7dc935a9778e5413
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jul 19 04:44:44 2014 -0500
- library: evolve MenAvailable algorithm on older kernel
- Let's not report zero for kb_main_available when older
- kernels don't have MemAvailable. Instead, if we simply
- duplicate the 'free' amount we can avoid all ancillary
- problems, such as those involving top's graphing mode.
- Reference(s):
- http://www.freelists.org/post/procps/kb-main-available-etc,3
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 7391699b0748724b5d3024df4f01d2571bd29fc1
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jul 18 08:55:08 2014 -0500
- top: correct one grammatical error in the man document
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit d310a18fc2391ba06f3531aff020c97057c0ed3c
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jul 17 13:13:13 2014 -0500
- top: exploit new kb_main_available, make Jaromir happy
- This patch will trade a former pessimistic calculation
- of free physical memory for a more optimistic one that
- uses the newly added kb_main_available library export.
- But in case one might wish to return to the old former
- method, there's a new #define that was made available.
- [ the new calculation will affect graphing mode only ]
- Reference(s):
- http://www.freelists.org/post/procps/systemd-support-to-library,9
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 9500dc198c6347768a71cdf4a6a2a8d5cba903f3
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jul 17 12:12:12 2014 -0500
- top: trade Page_size for that newly exposed page_bytes
- Might as well use the newly exposed sysinfo.h variable
- 'page_bytes' rather than our own. Plus, in the process
- we can avoid incurring yet one more function call hit.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit e4f0b4ebf3eaa1bda9a0315ec7b113c73a510dd4
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jul 17 11:11:11 2014 -0500
- library: tweak newly added MemAvailable fall-back code
- This commit just ensures recalculation of some amounts
- for iterative processes, like top. It also trades some
- repeated runtime calls to sysconf for a one time cost.
- Reference(s):
- http://www.freelists.org/post/procps/systemd-support-to-library,7
- . fall-back calculations
- commit b779855cf15d68f9038ff1809db18c0788e9ae70
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 6c148b4f8b2acfaf1edae9f8e92e91bdeb723e72
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jul 17 10:10:10 2014 -0500
- docs: with systemd now in library, remember openproc.3
- [ plus remove just a little darn trailing whitespace ]
- Reference(s):
- . systemd migrated to library
- commit 9d8ad6419f9f16978b7e9e769b7acb085f317058
- . added library documentation
- commit a74fb8fade82ad624703bb1bc7395cf0aacaeaa9
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 1da2c98937d91676e485557f8197249453547306
- Author: Jim Warner <james.warner@comcast.net>
- Date: Wed Jul 16 00:00:00 2014 -0500
- library: disable a potential 'ELF note' is missing msg
- The stderr message regarding ELF notes appears on some
- systems (openSUSE-13.1 for example) but I have not yet
- isolated why. Since at startup we go on to determine a
- Hertz value the old fashion way, this patch just turns
- off the useless message until the cause is understood.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 93d37cf57a9d3c4437c5ed660007d2c471c6daee
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 28 00:00:33 2014 -0500
- ps: exploit library systemd support vs. internal logic
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 9d8ad6419f9f16978b7e9e769b7acb085f317058
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 28 00:00:22 2014 -0500
- library: generalize then add former 'ps' systemd logic
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit d18730485435188946ca773c372cca162a9ad696
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 28 00:00:11 2014 -0500
- ps: clarify which options depend on systemd in man doc
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 6cd8691720a470c20b5aace7186a7f1984d82930
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jul 4 00:00:00 2014 -0500
- top: fix potential 'nan', should a system have no Swap
- Gosh, just because most of us might run with some swap
- file allocated, not every system might. I only wish my
- testing methodology was as sophisticated as Jaromir's.
- Reference(s):
- http://www.freelists.org/post/procps/latest-top-enhancements,7
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 1dd0c4d07f870351dedfbee83da0a140f76292b2
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jul 3 00:00:00 2014 -0500
- top: as with ps, distinguish between 'T' and 't' state
- Wow, even the linux/Documentation/filesystems/proc.txt
- document doesn't provide us with that level of detail.
- Thank you, Jaromir, for your additional clarification!
- Reference(s):
- commit 411d218793af1f7ef6db37b319c1b08a7ca7c9b8
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit a7741055f19c4273c7c17c8af4f89195d018c2ba
- Author: Jim Warner <james.warner@comcast.net>
- Date: Wed Jul 2 00:00:00 2014 -0500
- top: add another translation hint for graphs alignment
- This should be the last of this kind of crap. I'll get
- to work on some means to no longer burden a translator
- with lengths requirements. Ideally each word should be
- allowed to stand alone and the minimum/maximum lengths
- handled programmatically when our ol' top is executed.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 206570e8c453104457b6179ff922e74d3a5fba96
- Author: Jim Warner <james.warner@comcast.net>
- Date: Tue Jul 1 00:00:00 2014 -0500
- top: with new startup defaults, tweak the man document
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit c75586f5238fb65708404641eb6cde6c1a403c84
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Jun 30 00:00:00 2014 -0500
- top: eliminated unreferenced macros & an error message
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 8ef6cd91fc5df6372a93bc4a37cbad34ead9654e
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sun Jun 29 00:00:00 2014 -0500
- top: retire old stale startup defaults in favor of new
- For over a decade top has used a startup configuration
- mimicking the original redhat top. This decision dates
- back to when the forked Sourceforge version was trying
- to win over users in battles with that ancient kludge.
- Will anybody deny that those defaults are coyote ugly?
- Well, it is time that top presented a more modern look
- at startup, providing that no saved rcfile exists. But
- just in case some distro prefers that old, comfortable
- look, there's the '--disable-modern-top' build option.
- [ Pssst. With the widened memory fields it turns out ]
- [ the 'Mem' default window had become almost useless ]
- [ on an 80x24 terminal since %CPU & COMMAND were out ]
- [ of view. So some other defaults were tweaked a bit ]
- [ whether or not --disable-modern-top was specified. ]
- Reference(s)
- http://www.freelists.org/post/procps/tops-graph-mode-saga-continues,3
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 2199af404a92cac238728564f2f022255c5716ce
- Author: Jim Warner <james.warner@comcast.net>
- Date: Sat Jun 28 00:00:00 2014 -0500
- top: maximize recent locale aware numeric enhancements
- When startup argument parsing was recently enhanced to
- account for LC_NUMERIC settings, some user input logic
- dealing with numbers fails to exploit that capability.
- This patch extends such enhancements to a running top.
- Reference(s):
- commit f7b84f45c7ae99c276de9954fc16cdc4ff7f36f0
- http://www.freelists.org/post/procps/topwatch-floating-point-input,2
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 96c330e3b33aeec75d5210b8bd9e4c33e4135a13
- Author: Jim Warner <james.warner@comcast.net>
- Date: Fri Jun 27 00:00:00 2014 -0500
- top: afford each window its own cpu/memory graph modes
- When those new cpu/memory graphs modes were introduced
- they had global impact. In other words, the modes that
- were chosen for a 'current' window affect Summary Area
- appearance for every other window as well, even though
- each window sets unique View_STATES/View_MEMORY flags.
- I do not know how widespread the use of top's separate
- window provisions is, but I do know that documentation
- promises every window (field group) provides "a unique
- separately configurable summary area". And even though
- that promise does not include memory scaling (separate
- 'E' command) the graph modes are integral to 't' & 'm'
- and those were already observed on a per window basis.
- So this patch just takes the cpu and memory graph mode
- values out of global scope in the configuration file &
- gives each window its own unique pair of graph values.
- Reference(s):
- commit 1d171ec74163f3103e7b230ee63818df04b4526f
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit 805532ac32610279f381e2510b8cbaac6c625903
- Author: Jim Warner <james.warner@comcast.net>
- Date: Thu Jun 26 00:00:00 2014 -0500
- top: fix translation hint to preserve graphs alignment
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit f7b84f45c7ae99c276de9954fc16cdc4ff7f36f0
- Author: Jim Warner <james.warner@comcast.net>
- Date: Wed Jun 25 00:00:00 2014 -0500
- top: tweak argument parsing for some locale situations
- Boy I hate locale stuff. For code I thought was pretty
- robust, Jaromir sure proved that it wasn't. Anyway, me
- thinks this commit closes some gaps and will cause top
- to behave appropriately under various locale settings.
- It does *not* permit top to respond to the ',' and '.'
- floating point separator without regard to the locale.
- It does, however, enforce proper LC_NUMERIC responses.
- Let's look on this commit as an interim solution until
- Jaromir can create that proposed 'fp_decode' function.
- Who knows, he might even borrow some of our mkfloat().
- [ An aside: the coreutils sleep and timeout programs ]
- [ claim to permit floating point arguments. However, ]
- [ neither one will accept the comma separator should ]
- [ the locale be a country that in fact uses a comma. ]
- [ In other words, with this commit we are way ahead! ]
- Reference(s):
- http://www.freelists.org/post/procps/topwatch-floating-point-input
- http://www.freelists.org/post/procps/topwatch-floating-point-input,1
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit cec19765115e9c65c52412c16d03f8d515506d7e
- Author: Jim Warner <james.warner@comcast.net>
- Date: Tue Jun 24 00:00:00 2014 -0500
- top: let's not pretend top can catch SIGKILL & SIGSTOP
- While there was no harm done setting a handler for the
- above two signals, they are in fact uncatchable. Thus,
- whenever we ran with valgrind we're politely reminded.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- commit db6381ae043ffd4aa9fd5788f434af155ae096f1
- Author: Jim Warner <james.warner@comcast.net>
- Date: Mon Jun 23 00:00:00 2014 -0500
- top: scale length for new graphs to a terminal's width
- When the beginning of the Mem/Swap graphs was variable
- scaling them to the current terminal's width was a bit
- of a costly nightmare. So the graph size was fixed and
- subject to truncation. However now that the start of a
- graph can be easily predicted, I've revisited scaling.
- As it turns out, any cost is minimal & mostly incurred
- at an opportune time, at SIGWINCH or user interaction.
- Plus, most of the apparent arithmetic is actually just
- a means of documenting and will disappear thru compile
- time constants in the ultimate generated machine code.
- Note: those graphs will now behave just like any other
- Summary Area element - they will scale from full sized
- down to a terminal width of 80 columns, at which point
- those displayed graphs are then subject to truncation.
- Signed-off-by: Jim Warner <james.warner@comcast.net>
- ...
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement