PVS-StudioWarnings

PVS-Studio warning V597 for NSS

Nov 24th, 2014
185
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.78 KB | None | 0 0
  1. SECStatus
  2. SHA384_HashBuf(unsigned char *dest, const unsigned char *src,
  3.                PRUint32 src_length)
  4. {
  5.   SHA512Context ctx;
  6.   unsigned int outLen;
  7.  
  8.   SHA384_Begin(&ctx);
  9.   SHA512_Update(&ctx, src, src_length);
  10.   SHA512_End(&ctx, dest, &outLen, SHA384_LENGTH);
  11.   memset(&ctx, 0, sizeof ctx);
  12.  
  13.   return SECSuccess;
  14. }
  15.  
  16. This suspicious code was found in NSS project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V597 The compiler could delete the 'memset' function call, which is used to flush 'ctx' object. The RtlSecureZeroMemory() function should be used to erase the private data. sha512.c 1423
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment