[12:01:34pm] <@Collision> ugh
[12:01:36pm] <@Collision> i forgot the simc addon broke
[12:03:28pm] [12:03:28pm] Alogon (Alogon@97-86-41-93.dhcp.stpt.wi.charter.com) has joined.  «38 people»
[12:03:47pm] [12:03:47pm] omelette «5a0ca512@97-86-41-93.dhcp.stpt.wi.charter.com» has Quit iRC (Ping timeout) «37 people»
[12:08:29pm] <aggixx> almost forgot that addon even existed
[12:08:31pm] <aggixx> what's broken about it?
[12:08:39pm] <@Collision> bonus ids changed somehow in the client
[12:08:56pm] <@reia> maybe they added something to the tooltip info
[12:10:24pm] <gahddo> that was theck's project right?
[12:10:42pm] <gahddo> *is
[12:17:22pm] <@Collision> hrm
[12:17:24pm] <@Collision> specifically
[12:17:29pm] <@Collision> callbackhandler-1.0 ace library
[12:17:32pm] <@Collision> is broken it seems
[12:20:40pm] <aggixx> oh, ace stuff
[12:26:51pm] <aggixx> that felmouth frenzy food is so weird
[12:27:01pm] <aggixx> its like cunning of the cruel, food edition
[12:29:44pm] <@Collision> Message: Interface\AddOns\simulationcraft\core.lua:171: attempt to perform arithmetic on upvalue 'simc_err_str' (a string value
[12:31:45pm] <@Collision> i removed simc_err_str references and it works fine
[12:31:48pm] <@Collision> sorta
[12:31:57pm] <@Collision> legs=,id=115580,bonus_id=2/562/567
[12:32:00pm] <@Collision> don't think 2 is a bonus id
[12:33:36pm] <aggixx> thats weird
[12:33:53pm] <aggixx> why would you perform arithmetic on variable that's obvious intended to be a string
[12:34:53pm] <@Collision> looks like they removed upgradeLevel from items
[12:35:07pm] <@Collision> and it's now tripping a line of code in teh addon that never was used
[12:35:25pm] <@Collision>       if upgradeLevel == nil then
[12:35:25pm] <@Collision>         upgradeLevel = 0
[12:35:25pm] <@Collision>         simc_err_str = simc_err_str + '\n # WARNING: upgradeLevel nil for upgradeId ' .. upgradeId .. ' in itemString ' .. itemString
[12:35:25pm] <@Collision>       end
[12:35:32pm] <aggixx> ahhh
[12:35:35pm] <aggixx> yeah just change + to ..
[12:35:47pm] <@Collision> apparently 1/2 are bonus ids
[12:35:51pm] <aggixx> + is arithmetic only in lua
[12:36:26pm] <@Collision> finger2=,id=113940,bonus_id=1/567,enchant_id=5324
[12:36:26pm] <@Collision> trinket1=,id=124523,bonus_id=0
[12:36:26pm] <@Collision> trinket2=,id=124238,bonus_id=0
[12:36:26pm] <@Collision> main_hand=,id=113953,bonus_id=2/562/567,enchant_id=5330
[12:36:26pm] <@Collision> off_hand=,id=113953,bonus_id=2/565/567,gem_id=115809,enchant_id=5330
[12:36:27pm] <@Collision> examples
[12:37:18pm] <@reia> er
[12:37:21pm] <@reia> removed upgrade ids?
[12:37:32pm] <@Collision> yeah, appears that way, otherwise that line woudlnt' be tripped
[12:37:33pm] <@reia> err, upgrade levels
[12:37:39pm] <@reia> no but
[12:37:46pm] <@reia> do you have an item with upgrade level in bank or something
[12:37:50pm] <@reia> because that's a bit confusing
[12:37:52pm] <@Collision> let me checkj
[12:38:58pm] <@Collision> yeah i have one
[12:39:00pm] <@Collision> it is still upgraded
[12:39:31pm] <@Collision> trinket1=,id=96915
[12:39:36pm] <@Collision> is the output, tho
[12:40:29pm] <@reia> so the upgrade id disappears?
[12:40:31pm] <@reia> from simc output
[12:40:33pm] <@Collision> yeah
[12:40:40pm] <@reia> hum
[12:40:48pm] <@reia> i'll try to take a look over the weekend
[12:41:02pm] <@Collision> ignoring the shitloads of errors
[12:41:02pm] <@Collision> http://collision.heroicstrike.org/2015-05-28_13-40-26.png
[12:41:20pm] <@Collision> it has the correct stats
[12:41:22pm] <@reia> hmm
[12:41:31pm] <@reia> i'm not seeing upgrade id
[12:41:34pm] <@reia> in that set
[12:41:42pm] <@reia> is it just covered by that errorbox
[12:41:43pm] <@Collision> http://collision.heroicstrike.org/2015-05-28_13-41-10.png
[12:41:46pm] <@Collision> there we go
[12:42:08pm] <@reia> hm
[12:42:12pm] <@Collision> 1146034816 seems legit
[12:42:25pm] <@reia> it's an unique id for that item (that you possess)
[12:42:31pm] [12:42:31pm] Manager (Manager@97-86-41-93.dhcp.stpt.wi.charter.com) has joined.  «38 people»
[12:42:51pm] <@reia> i guess 467 is the upgrade id, i'd have to dig the code
[12:43:02pm] <@Collision> ah ,yeah
[12:43:03pm] <@reia> hmm, or maybe that's thunderforged actually
[12:43:06pm] <@Collision> maybe
[12:43:47pm] <@Collision> yeah it's thudnerforged
[12:44:34pm] [12:44:34pm] Gen (Genetics@97-86-41-93.dhcp.stpt.wi.charter.com) has joined.  «39 people»
[12:53:42pm] [12:53:42pm] Delirium (680a9992@97-86-41-93.dhcp.stpt.wi.charter.com) has joined.  «40 people»
[12:56:00pm] <aggixx> it looks like that's not the whole itemstring?
[12:56:12pm] <aggixx> 4:0:0:467 doesn't make sense if 4 is # of bonus IDs
[12:56:57pm] <aggixx> you can just do /dump ""
[12:57:04pm] <aggixx> and shiftclick the item into the quotation marks
[12:58:31pm] <@Collision> nope, that's literally it
[12:58:34pm] <@Collision> just tried that
[12:58:39pm] <@Collision> same line
[12:58:45pm] <aggixx> hmm
[12:59:01pm] <aggixx> maybe its bugged and not showing the 4th bonus ID in the itemstring?
[12:59:07pm] <aggixx> cause there should be 4
[1:02:17pm] [1:02:17pm] Cyclonus-work (Cyclonuswr@97-86-41-93.dhcp.stpt.wi.charter.com) has joined.  «41 people»
[1:05:16pm] <Cyclonus-work> Collision what sort of ST dps are you doing on dummys as fury now? If you tried.
[1:06:26pm] <@Collision> ranges from 52-57k
[1:07:01pm] <Cyclonus-work> yeah.. so i'm way off. was seeing maybe 46k, but 55k np as gladiator.
[1:07:10pm] <Cyclonus-work> I need to practice :)
[1:10:02pm] <aggixx> I guess another option is that there isn't numBonusIDs anymore
[1:10:05pm] <aggixx> and that that 4 is something else
[1:10:18pm] <@reia> well i'm wondering where the upgrade level disappeared
[1:12:25pm] <@reia> aha
[1:12:26pm] <aggixx> I think its a bonusID and just getting clipped somehow on collision's item
[1:12:27pm] [1:12:26pm] eein «smuxi@97-86-41-93.dhcp.stpt.wi.charter.com» has Quit iRC (Client closed connection) «40 people»
[1:12:32pm] <@reia> 467 is the upgrade id
[1:12:57pm] <@reia> so hmm
[1:13:00pm] <aggixx> where's the thunderforged then :P
[1:13:04pm] <@reia> in the item
[1:13:05pm] <@reia> this is old world
[1:13:08pm] <@reia> there's no bonus ids
[1:13:14pm] <aggixx> ohhh yeah okay
[1:13:27pm] <aggixx> I was thinking tf was a bonus ID but difficulty wasnt
[1:13:35pm] <@reia> nah
[1:13:44pm] <aggixx> but you're right that doesnt make sense
[1:13:45pm] <@reia> so, our code presumes upgrade id is the 10th or 11th element
[1:13:52pm] <@reia> by my calculations from collision's figure
[1:14:03pm] <@reia> it's 14th
[1:14:17pm] <aggixx> well, its in the list of bonus ids
[1:14:22pm] <aggixx> you can't just use a fixed #
[1:14:25pm] <@reia> it's not
[1:14:31pm] <@reia> the way things at least initially were set up
[1:14:37pm] <@reia> is that the items that are from the old world
[1:14:48pm] <@reia> don't have the number of bonus ids element at all
[1:14:57pm] <@reia> and that's also how the addon works
[1:15:02pm] <aggixx> ohhhh okay that would make a lot more sense
[1:15:06pm] <@reia> if wowversion is > 6.0
[1:15:15pm] <@reia> #bonus ids is the 12th element
[1:15:20pm] <@reia> if <6.0
[1:15:24pm] <@reia> there's no such thing
[1:15:33pm] <@reia> and also, upgrade id is 10th element
[1:16:07pm] <aggixx> not sure why they'd bother changing it then lol
[1:16:16pm] <@reia> well, based on that picture
[1:16:23pm] <@reia> they added some new fields for whatever reason
[1:16:23pm] <aggixx> oh, it removes an element for WoD+ links
[1:16:29pm] <@reia> hm?
[1:16:44pm] <aggixx> WoD items don't need a upgradeId field now right?
[1:16:46pm] <aggixx> or did they not have it before
[1:16:54pm] <@reia> they did have an upgradeid field
[1:17:03pm] <@reia> it was just always 0
[1:17:07pm] <aggixx> yeah okay makes sense then
[1:17:08pm] <@reia> now, i don't know
[1:17:16pm] <@reia> collision did not provide an item with bonus ids
[1:17:20pm] <@reia> or a picture of one
[1:17:24pm] <@reia> so cant compare to this gaze of the twins
[1:17:39pm] <aggixx> Dump: value=" [Living Wood Legguards]"
[1:17:39pm] <aggixx> [1]=" |cffa335ee|Hitem:115543:0:0:0:0:0:0:0:100:103:0:6:2:562:567|h[Living Wood Legguards]|h|r"
[1:17:44pm] <aggixx> 706 tier legs
[1:17:54pm] <aggixx> (thats on PTR obviously)
[1:18:08pm] <@reia> ok so
[1:18:46pm] <@reia> they seem to have added a single field between upgrade id and #bonus id?
[1:18:52pm] <@reia> that "6"
[1:19:03pm] <aggixx> 6 is difficulty ID I think?
[1:19:13pm] <@reia> maybe, i dont know
[1:19:20pm] <@reia> does difficulty now show on tooltips?
[1:19:39pm] <aggixx> yeah its difficulty ID
[1:19:46pm] <aggixx> thats been in since wod
[1:19:46pm] <aggixx> http://www.wowinterface.com/forums/showthread.php?t=49503
[1:19:47pm] <@reia> what does /dump GetBuildInfo() give
[1:20:01pm] <aggixx> Dump: value=GetBuildInfo()
[1:20:01pm] <aggixx> [1]="6.2.0",
[1:20:01pm] <aggixx> [2]="20061",
[1:20:01pm] <aggixx> [3]="May 25 2015",
[1:20:01pm] <aggixx> [4]=60200
[1:20:34pm] <@reia> well then simc addon has been broken forever, i guess
[1:20:45pm] <@reia> hmm no
[1:20:48pm] <@reia> okay, yeah
[1:20:50pm] <aggixx> unless this post is outdated
[1:20:51pm] <@reia> 10 and 12 for >=6.0
[1:20:55pm] <aggixx> which is possible
[1:20:57pm] <@reia> nah
[1:21:03pm] <@reia> it's 10 and 12 for >= 6.0
[1:21:08pm] <@reia> and before that, 11
[1:21:10pm] <@reia> (reforging is gone)
[1:21:41pm] <@reia> yeah, so they added a field somewhere in there
[1:21:50pm] <aggixx> 100:103:0
[1:21:51pm] <aggixx> what's 103
[1:22:03pm] <@reia> the new field, mayhaps
[1:23:03pm] <aggixx> everything returns 103
[1:23:22pm] <@reia> Collision: you can fix the addon probably
[1:23:42pm] <@reia> by changing OFFSET_HAS_BONUS to 13
[1:23:53pm] <@reia> and OFFSET_UPGRADE_ID to 11
[1:29:41pm] <Manager> that fixed both of my addons reia
[1:30:02pm] <@reia> both addons?
[1:30:16pm] <Manager> i use another addon to show the bonus ID of things
[1:30:19pm] <Manager> it broke as well
[1:30:39pm] <@reia> oh
[1:44:59pm] <aggixx> apparently nobody in wow ui irc knows what the new field is, so yeah
[1:45:30pm] <aggixx> modifying it doesn't change the tooltip, and everything I can find is 103, so seemingly its not very important
[1:50:09pm] <aggixx> oh figured it out
[1:50:16pm] <aggixx> its specialization id
[1:50:21pm] <@reia> ah yes
[1:50:25pm] <@reia> for class trinket displays
[1:50:37pm] <@reia> they also added specialization id to item data
[1:50:46pm] <@reia> well, more specifically item effect data