PVS-StudioWarnings

PVS-Studio warning V547 for Firebird

Nov 19th, 2014
173
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.62 KB | None | 0 0
  1. static bool get_switches(....)
  2.   ....
  3.   if (**argv != 'n' || **argv != 'N')
  4.   {
  5.     fprintf(stderr,
  6.       "-sqlda :  Deprecated Feature: you must use XSQLDA\n ");
  7.     print_switches();
  8.     return false;
  9.   }
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in Firebird project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V547 Expression '* * argv != 'n' || * * argv != 'N'' is always true. Probably the '&&' operator should be used here. gpre.cpp 1829
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment