Advertisement
PVS-StudioWarnings

PVS-Studio warning V616 for Firefox

Nov 27th, 2014
161
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. enum nsBorderStyle {
  2.   eBorderStyle_none = 0,
  3.   ....
  4. };
  5.  
  6. NS_IMETHODIMP
  7. nsWindow::SetNonClientMargins(nsIntMargin &margins)
  8. {
  9.   if (!mIsTopWidgetWindow ||
  10.       mBorderStyle & eBorderStyle_none ||
  11.       mHideChrome)
  12.     return NS_ERROR_INVALID_ARG;
  13.   ....
  14. }
  15.  
  16. Most likely this is what should be written here: mBorderStyle != eBorderStyle_none
  17.  
  18. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V616 The 'eBorderStyle_none' named constant with the value of 0 is used in the bitwise operation. nswindow.cpp 2278
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement