bnto code

#include <iostream>
#include <cstdlib>
#include <ctime>
using std::cout;
using std::cin;
using std::endl;
short generar() {
    return rand() % 40 + 1;
}
short mayor(short *n1, short *n2, short*n3, short *n4) {
    int m = 0;
    if (*n1 > *n2&&*n1 > *n3&&*n1 > *n4)m= *n1;
    else if (*n2 > *n1&&*n2 > *n3&&*n2 > *n4)m= *n2;
    else if (*n3 > *n1&&*n3 > *n2&&*n3 > *n4)m= *n3;
    else if (*n4 > *n1&&*n4 > *n2&&*n4 > *n3)m= *n4;
    return m;
}
short menor(short *n1, short *n2, short*n3, short *n4) {
    int m = 0;
    if (*n1 < *n2&&*n1 < *n3&&*n1 < *n4)m= *n1;
    else if (*n2 < *n1&&*n2 < *n3&&*n2 <*n4)m= *n2;
    else if (*n3 < *n1&&*n3 < *n2&&*n3 <*n4)m= *n3;
    else if (*n4 < *n1&&*n4 < *n2&&*n4 <*n3)m= *n4;
    return m;
}
short menormayor(short *n1, short *n2, short*n3, short *n4) {
    short ma = mayor(n1, n2, n3, n4);
    short t;
    if (ma == *n1) { t=mayor(new short(0), n2, n3, n4); }
    else if (ma == *n2) { t = mayor(n1,new short(0), n3, n4); }
    else if (ma == *n3) { t = mayor(n1,n2 ,new short(0), n4); }
    else if (ma == *n4) { t = mayor(n1,n2, n3, new short(0)); }
    return t;
}
int main() {

    short *n1, *n2, *n3, *n4;
    n1 = new short;
    n2 = new short;
    n3 = new short;
    n4 = new short;
    srand(time(NULL));
    *n1 = generar();
    *n2 = generar();
    *n3 = generar();
    *n4 = generar();
    cout << *n1 << " " << *n2 << " " << *n3 << " " << *n4 << endl;
    cout << mayor(n1, n2, n3, n4)<<endl;
    cout << menor(n1, n2, n3, n4)<<endl;
    cout << menormayor(n1, n2, n3, n4) << endl;
    cin.get();
    cin.ignore();
    return 0;

}