PVS-StudioWarnings

PVS-Studio warning V547 for TPP

Nov 19th, 2014
178
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.63 KB | None | 0 0
  1. bool TandemResultsParser::writePepXML(....)
  2. {
  3.   ...
  4.   char c = pathSummary.at(pathSummary.length() - 1);
  5.   if (c != '\\' || c != '/')
  6.   ...
  7. }
  8.  
  9. This is what should have been written here:
  10. if (c != '\\' && c != '/')
  11.  
  12. This suspicious code was found in TPP project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V547 Expression 'c != '\\' || c != '/'' is always true. Probably the '&&' operator should be used here. Tandem2XML tandemresultsparser.cxx 787
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment