PVS-StudioWarnings

PVS-Studio warning V501 for Clang

Nov 11th, 2014
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.80 KB | None | 0 0
  1. Instruction *InstCombiner::visitXor(BinaryOperator &I) {
  2.   ...
  3.   if (Op0I && Op1I && Op0I->isShift() &&
  4.       Op0I->getOpcode() == Op1I->getOpcode() &&
  5.       Op0I->getOperand(1) == Op1I->getOperand(1) &&
  6.       (Op1I->hasOneUse() || Op1I->hasOneUse())) {
  7.   ...
  8. }
  9.  
  10. Most likely this is what should be written here: (Op0I->hasOneUse() || Op1I->hasOneUse()).
  11.  
  12. This suspicious code was found in Clang project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V501 There are identical sub-expressions to the left and to the right of the '||' operator: Op1I->hasOneUse () || Op1I->hasOneUse () LLVMInstCombine instcombineandorxor.cpp 2246
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment