PVS-StudioWarnings

PVS-Studio warning V629 for Clang

Nov 18th, 2014
170
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.62 KB | None | 0 0
  1. int64_t DataExtractor::getSLEB128(....) const {
  2.   int64_t result = 0;
  3.   ...
  4.   // Sign bit of byte is 2nd high order bit (0x40)
  5.   if (shift < 64 && (byte & 0x40))
  6.     result |= -(1 << shift);
  7.   ...
  8. }
  9.  
  10. This suspicious code was found in Clang project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V629 Consider inspecting the '1 << shift' expression. Bit shifting of the 32-bit value with a subsequent expansion to the 64-bit type. dataextractor.cpp 171
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment