PVS-StudioWarnings

PVS-Studio warning V597 for NSS

Nov 12th, 2014
172
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.80 KB | None | 0 0
  1. #define PORT_Memset   memset
  2.  
  3. static SECStatus ssl2_ClientSetupSessionCypher(....)
  4. {
  5.   ....
  6.   PRUint8 keyData[SSL_MAX_MASTER_KEY_BYTES];
  7.   ....
  8.   loser2:
  9.   done:
  10.     PORT_Memset(keyData, 0, sizeof(keyData));
  11.     PORT_ZFree(ekbuf, modulusLen);
  12.     PORT_ZFree(eblock, modulusLen);
  13.     SECKEY_DestroyPublicKey(serverKey);
  14.     return rv;
  15. }
  16.  
  17. This suspicious code was found in NSS project by PVS-Studio static code analyzer.
  18. Warning message is:
  19. V597 The compiler could delete the 'memset' function call, which is used to flush 'keyData' buffer. The RtlSecureZeroMemory() function should be used to erase the private data. sslcon.c 2151
  20.  
  21. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment