Advertisement
krames12

Feedback on Grav Theme

Feb 4th, 2017
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 1.85 KB | None | 0 0
  1. - Use Schema.org markup, eg. https://schema.org/Person
  2. - Why is the title of some pages a `h2` tag? Titles of pages should be a `h1` tag, titles of sections should be a `h2` tag, titles of subsections should be a `h3` tag, etc
  3. - Use the Open Graph protocol (http://ogp.me/) and Twitter cards (https://dev.twitter.com/cards/overview)
  4. - Deploy TLS, use https://mozilla.github.io/server-side-tls/ssl-config-generator/, btw you shouldn't forget HSTS, and preferably preload it with https://hstspreload.org/
  5. - When you've deployed TLS, you could also deploy HTTP/2 and Brotli
  6. - Deploy security headers: `X-Frame-Options`, `X-XSS-Protection`, `X-Content-Type-Options`, and if you can, `Content-Security-Policy`
  7. - Set the `lang` attribute of the `html` tag to `en`
  8. - Set the `description` `meta` tag to something meaningful
  9. - Make `.header` a `header` tag
  10. - Make the `.project-nav` a `nav` tag (or set it's `role` attribute to `navigation`)
  11. - Wrap the main content specific to a page in a `main` tag
  12. - The contrast of the green and white colors of selected things is too low, see http://webaim.org/resources/contrastchecker/?fcolor=ffffff&bcolor=99cc99
  13. - You toggle `.active` in the hamburger menu, but you don't toggle the relevant ARIA attribute: `aria-expanded`
  14. - Make sure the website is fully browsable with just Tab and Enter
  15. - A maximum width for the site wrapper doesn't look right at 4K, eg. Chrome's device toolbar is handy for testing that if you don't have a 4K screen
  16. - Make the `alt` attribute of `img` tags tell what the image shows
  17. - Why are project names a `p` tag? A name isn't a whole paragraph of text, so a `span` tag would be better or maybe a `strong` or a heading tag
  18. - There's something wrong with the email link
  19. - Set `aria-hidden` to `true` at `#nav-toggle` when it's hidden
  20. - You're using multiple CDNs, you want to only use one, like cdnjs or jsDelivr
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement