Untitled

Envelope-to: aeikum@codeweavers.com
Delivery-date: Wed, 18 Jan 2012 08:58:44 -0600
Date: Wed, 18 Jan 2012 08:58:08 -0600
From: Andrew Eikum <aeikum@codeweavers.com>
To: alsa-devel <alsa-devel@alsa-project.org>
Message-ID: <20120118145808.GR24575@foghorn.codeweavers.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="yzvKDKJiLNESc64M"
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: [alsa-devel] [alsa-lib PATCH] Document strdup allocation in
 snd_card_get_name family
Precedence: list
Reply-To: alsa-devel <alsa-devel@alsa-project.org>,
	Andrew Eikum <aeikum@codeweavers.com>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
Content-Transfer-Encoding: 7bit


--yzvKDKJiLNESc64M
Content-Type: text/plain; charset=utf-8; format=fixed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This was spotted by J=C3=B6rg H=C3=B6hle on the wine-patches ML.

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
---

I noticed my documentation patches haven't been making their way into
alsa-lib.git. Am I submitting these wrong? I added the SOB line above,
although I notice not all patches that get into ALSA have it. On the
other hand, alsa-lib.git hasn't been changed since November so perhaps
my patches are sitting in someone's tree waiting to be pushed :)

Please let me know if I can help get these in.

 src/control/cards.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


--yzvKDKJiLNESc64M
Content-Type: text/x-patch; charset=us-ascii;
	name="0001-Document-strdup-allocation-in-snd_card_get_name-fami.patch"
Content-Disposition: inline; filename="0001-Document-strdup-allocation-in-snd_card_get_name-fami.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/control/cards.c b/src/control/cards.c
index 0bb8f86..b528e33 100644
--- a/src/control/cards.c
+++ b/src/control/cards.c
@@ -166,6 +166,9 @@ int snd_card_get_index(const char *string)
  * \param card Card number
  * \param name Result - card name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_name(int card, char **name)
 {
@@ -193,6 +196,9 @@ int snd_card_get_name(int card, char **name)
  * \param card Card number
  * \param name Result - card long name corresponding to card number
  * \result zero if success, otherwise a negative error code
+ *
+ * The value returned in name is allocated with strdup and should be
+ * freed when no longer used.
  */
 int snd_card_get_longname(int card, char **name)
 {

--yzvKDKJiLNESc64M
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--yzvKDKJiLNESc64M--