PVS-StudioWarnings

PVS-Studio warning V517 for Chromium

Nov 11th, 2014
188
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. static GLenum
  2. get_temp_image_type(GLcontext *ctx, GLenum baseFormat)
  3. {
  4.   ...
  5.   if (ctx->DrawBuffer->Visual.redBits <= 8)       <<<---
  6.      return GL_UNSIGNED_BYTE;
  7.   else if (ctx->DrawBuffer->Visual.redBits <= 8)  <<<---
  8.      return GL_UNSIGNED_SHORT;
  9.   else
  10.      return GL_FLOAT;
  11.   ...
  12. }
  13.  
  14. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 2520, 2522. osmesa meta.c 2520
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment