PVS-StudioWarnings

PVS-Studio warning V501 for Chromium

Nov 19th, 2014
222
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.74 KB | None | 0 0
  1. bool IsTextField(const FormFieldData& field) {
  2.   return
  3.     field.form_control_type == "text" ||
  4.     field.form_control_type == "search" ||
  5.     field.form_control_type == "tel" ||
  6.     field.form_control_type == "url" ||
  7.     field.form_control_type == "email" ||
  8.     field.form_control_type == "text";
  9. }
  10.  
  11. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V501 There are identical sub-expressions 'field.form_control_type == "text"' to the left and to the right of the '||' operator. autocomplete_history_manager.cc 35
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment