for s in string:
    new_string.append(s.split("--"))

string = ["12345--ABC-1234--This is test", "12346--ABC-1234--This is test", "22222--BCD-4321--Another one"]

Expected output: new_string  = ["22222--BCD-4321--Another one", "12346--ABC-1234--This is test"]