PVS-StudioWarnings

PVS-Studio warning V530 for IPP Samples

Nov 20th, 2014
158
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 1.10 KB | None | 0 0
  1. void H264ThreadGroup::RemoveThread(H264Thread * thread)
  2. {
  3.     AutomaticUMCMutex guard(m_mGuard);
  4.     std::remove(m_threads.begin(), m_threads.end(), thread);
  5. }
  6.  
  7. The std::remove function does not remove elements from the container. It only shifts the elements and brings the iterator back to the beginning of the trash. Suppose we have the vector<int> container that contains elements 1,2,3,1,2,3,1,2,3. If we execute the code "remove( v.begin(), v.end(), 2 )", the container will contain elements 1,3,1,3,?,?,?, where ? is some trash. The function will bring the iterator back to the first senseless element, so if we want to remove these trash elements, we must write the code this way: "v.erase(remove(v.begin(), v.end(), 2), v.end())".
  8.  
  9. This suspicious code was found in IPP Samples project by PVS-Studio static code analyzer.
  10. Warning message is:
  11. V530 The return value of function 'remove' is required to be utilized. h264_dec umc_h264_thread.cpp 226
  12.  
  13. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment