PVS-StudioWarnings

PVS-Studio warning V541 for Pcsx2

Nov 18th, 2014
168
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.60 KB | None | 0 0
  1. void ListPatches (HWND hW) {
  2.   ...
  3.   while((tmpi=fgetc(fp)) != EOF)
  4.     sprintf(fileData,"%s%c",fileData,tmpi);
  5.   ...
  6.   sprintf(tmpStr,"%s (%s)",tmpStr,FindData.cFileName);
  7.   ...
  8. }
  9.  
  10. The code might work, but this is a dangerous game.
  11.  
  12. This suspicious code was found in Pcsx2 project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V541 It is dangerous to print the string 'fileData' into itself. pcsx2 patchbrowser.cpp 211
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment