View difference between Paste ID: pRS2nF1p and tUrCYMNQ

-/*
+
-    AYE
+
-
+
-    Tommy
+
-*/
+
 };
 
 // {icon, "title name", honored_kills, titleID}
-    uint32 menu_id;
+
 {
     {9, "Private", 1, 1 },
     {9, "Corporal", 100, 2 },
     {9, "Sergeant", 250, 3 },
     {9, "Master Sergeant", 500, 4 },
     {9, "Sergeant Major", 750, 5 },
     {9, "Knight", 1000, 6 },
     {9, "Knight-Lieutenant", 1500, 7 },
-    {1, 9, "Private", 1, 1 },
+    {9, "Knight-Captain", 2000, 8 },
-    {2, 9, "Corporal", 100, 2 },
+    {9, "Knight-Champion", 2500, 9 },
-    {3, 9, "Sergeant", 250, 3 },
+    {9, "Lieutenant Commander", 3000, 10 },
-    {4, 9, "Master Sergeant", 500, 4 },
+    {9, "Commander", 3500, 11 },
-    {5, 9, "Sergeant Major", 750, 5 },
+    {9, "Marshal", 4000, 12 },
-    {6, 9, "Knight", 1000, 6 },
+    {9, "Field Marshal", 4500, 13 },
-    {7, 9, "Knight-Lieutenant", 1500, 7 },
+    {9, "Grand Marshal", 5000, 14 },
-    {8, 9, "Knight-Captain", 2000, 8 },
+
-    {9, 9, "Knight-Champion", 2500, 9 },
+    {9, "Scout", 1, 15 },
-    {10, 9, "Lieutenant Commander", 3000, 10 },
+    {9, "Grunt", 100, 16 },
-    {11, 9, "Commander", 3500, 11 },
+    {9, "Sergeant", 250, 17 },
-    {12, 9, "Marshal", 4000, 12 },
+    {9, "Senior Sergeant", 500, 18 },
-    {13, 9, "Field Marshal", 4500, 13 },
+    {9, "First Sergeant", 750, 19 },
-    {14, 9, "Grand Marshal", 5000, 14 },
+    {9, "Stone Guard", 1000, 20 },
     {9, "Blood Guard", 1500, 21 },
-    {15, 9, "Scout", 1, 15 },
+    {9, "Legionnaire", 2000, 22 },
-    {16, 9, "Grunt", 100, 16 },
+    {9, "Centurion", 2500, 23 },
-    {17, 9, "Sergeant", 250, 17 },
+    {9, "Champion", 3000, 24 },
-    {18, 9, "Senior Sergeant", 500, 18 },
+    {9, "Lieutenant General", 3500, 25 },
-    {19, 9, "First Sergeant", 750, 19 },
+    {9, "General", 4000, 26 },
-    {20, 9, "Stone Guard", 1000, 20 },
+    {9, "Warlord", 4500, 27 },
-    {21, 9, "Blood Guard", 1500, 21 },
+    {9, "High Warlord", 5000, 28 },
-    {22, 9, "Legionnaire", 2000, 22 },
+
-    {23, 9, "Centurion", 2500, 23 },
+static const uint32 TITLES_SIZE = (sizeof(Titles) / sizeof(*Titles)); // NOTE, this was wrong. it was uint32 instead of *Titles or HonorGossip in the sizeof.
-    {24, 9, "Champion", 3000, 24 },
+
-    {25, 9, "Lieutenant General", 3500, 25 },
+
-    {26, 9, "General", 4000, 26 },
+
-    {27, 9, "Warlord", 4500, 27 },
+
-    {28, 9, "High Warlord", 5000, 28 },
+
 
     bool OnGossipHello(Player* player, Creature* creature)
     {
         player->ADD_GOSSIP_ITEM(0, "|TInterface\\icons\\INV_Misc_QuestionMark:30|tHow does this npc work?|r", GOSSIP_SENDER_MAIN, 100);
         player->ADD_GOSSIP_ITEM(4, "|TInterface\\icons\\Achievement_PVP_H_15:30|tHonorable Kills Titles|r", GOSSIP_SENDER_MAIN, 101);
         player->ADD_GOSSIP_ITEM(7, "|TInterface\\icons\\Ability_Spy:30|tNevermind|r", GOSSIP_SENDER_MAIN, 102);
         player->SEND_GOSSIP_MENU(DEFAULT_GOSSIP_MESSAGE, creature->GetGUID());
         return true;
     }
-		player->ADD_GOSSIP_ITEM(0, "|TInterface\\icons\\INV_Misc_QuestionMark:30|tHow does this npc work?|r", GOSSIP_SENDER_MAIN, 100);
+
-		player->ADD_GOSSIP_ITEM(4, "|TInterface\\icons\\Achievement_PVP_H_15:30|tHonorable Kills Titles|r", GOSSIP_SENDER_MAIN, 101);
+
-		player->ADD_GOSSIP_ITEM(7, "|TInterface\\icons\\Ability_Spy:30|tNevermind|r", GOSSIP_SENDER_MAIN, 102);
+
-        player->SEND_GOSSIP_MENU(1, creature->GetGUID());
+
         if (actions == 100)
         {
             ChatHandler(player->GetSession()).SendSysMessage("|cffff6060[Information]:|r This npc show you 2 different options,Honorable Kills Titles costed on LifeTime Kills,Devium WoW Titles show you our own titles |cffff0000[Patch Required]|r,and costed on [Devium Title Token].");
             OnGossipHello(player, creature);
         }
         else if(actions == 101)
         {
             if (player->GetTeamId() == ALLIANCE)
-		return false;
+                for (int i = 0; i < TITLES_SIZE/2; ++i)
-	}
+                    player->ADD_GOSSIP_ITEM(Titles[i].icon, Titles[i].name.c_str(), GOSSIP_SENDER_MAIN, i);
             else
                 for (int i = TITLES_SIZE/2; i < TITLES_SIZE; ++i)
-            if (player->GetTeam() == ALLIANCE)
+                    player->ADD_GOSSIP_ITEM(Titles[i].icon, Titles[i].name.c_str(), GOSSIP_SENDER_MAIN, i);
-                for (int i = 0; i < 14; i++)
+            player->ADD_GOSSIP_ITEM(GOSSIP_ICON_DOT, "<- Back", GOSSIP_SENDER_MAIN, 999);
-                    player->ADD_GOSSIP_ITEM(Titles[i].icon, Titles[i].name.c_str(), GOSSIP_SENDER_MAIN, Titles[i].menu_id);
+            player->SEND_GOSSIP_MENU(DEFAULT_GOSSIP_MESSAGE, creature->GetGUID());
         }
-                for (int i = 14; i < 28; i++)
+
-                    player->ADD_GOSSIP_ITEM(Titles[i].icon, Titles[i].name.c_str(), GOSSIP_SENDER_MAIN, Titles[i].menu_id);
+
-						player->ADD_GOSSIP_ITEM(GOSSIP_ICON_DOT, "<- Back", GOSSIP_SENDER_MAIN, 999);
+        else if (actions == 999) // NOTE main menu, no need to write the options twice, use the function like this.
-                        player->SEND_GOSSIP_MENU(1, creature->GetGUID());
+            OnGossipHello(player, creature);
         else if (actions < TITLES_SIZE) // must check so we wont accidently go overboard
         {
             if (player->HasTitle(Titles[actions].titleID))
                 player->GetSession()->SendNotification("You already have this title!");
-		else if (actions == 999)
+            else if (player->GetUInt32Value(PLAYER_FIELD_LIFETIME_HONORABLE_KILLS) < Titles[actions].HK)
                 player->GetSession()->SendNotification("You don't have enough kills!");
-		player->ADD_GOSSIP_ITEM(0, "|TInterface\\icons\\INV_Misc_QuestionMark:30|tHow does this npc work?|r", GOSSIP_SENDER_MAIN, 100);
+            else if (CharTitlesEntry const* titleEntry = sCharTitlesStore.LookupEntry(Titles[actions].titleID))
-		player->ADD_GOSSIP_ITEM(4, "|TInterface\\icons\\Achievement_PVP_H_15:30|tHonorable Kills Titles|r", GOSSIP_SENDER_MAIN, 101);
+
-		player->ADD_GOSSIP_ITEM(7, "|TInterface\\icons\\Ability_Spy:30|tNevermind|r", GOSSIP_SENDER_MAIN, 102);
+                player->SetTitle(titleEntry);
-        player->SEND_GOSSIP_MENU(1, creature->GetGUID());
+                player->GetSession()->SendAreaTriggerMessage("Title granted!");
             }
             OnGossipHello(player, creature);
-        for (int i = 0; i < sizeof(Titles) / sizeof(uint32); i++)
+
         return true; // NOTE always return true, unless you want to send the default gossip menu from DB
-            if (actions == Titles[i].menu_id)
+
 };
-                if (player->HasTitle(Titles[i].titleID))
+
-                {
+
-                    player->GetSession()->SendNotification("You already have this title!");
+
-                    return false;
+
-                }
+