View difference between Paste ID: UhLWp7Pd and k6C3M5L8

-/**
+<?php
- * PROJECT CLEVERWEB GENERAL LESSER LICENSE INFORMATION v3.1
+/*
- * ------------------------------------------------------------
+  Cleaned up and sped up.
- * Copyright (C) 2011-2012 Nicholas Jordon
+  1000 interations of producing 2000 char string:
- * All rights reserved
+    Original - 4.1486458778381 seconds
- * Package: Project CleverWeb
+    This rewrite - 2.3620591163635
- * http://ProjectCleverWeb.com
+    %43 percent improvement
- *
+*/
- * License:
+
- *   GNU LESSER GENERAL PUBLIC LICENSE VERSION 3
+function cw_randchar( $length=NULL, $case=NULL, $spaces=false){
- *
+  // setting $spaces to null, then checking if null, is a waste of resources and effort. Just set it to false. Then the user can switch it on if they desire.
- * This software is free software: you can redistribute it
+
- * and/or modify it under the terms of the GNU Lesser
+
- * General Public License as published by the Free Software
+    if(strpos($temp_length,',') !== false){ // strpos is faster/less resource intensive as strstr
- * Foundation, version 3 of the License, You may not use this
+      $temp_length = str_replace(',','',$temp_length); //str_replace is faster than preg_replace(). RegEx have there place, but are huge wastes of resources. Know when to use them and when not to. This is not a case where RegEx are needed.
- * software except in compliance with the license.
+
- *
+    $length = (is_numeric($temp_length))? $temp_length : strlen($length);
- * You may obtain a copy of the license at:
+
- *   http://www.gnu.org/licenses/lgpl-3.0.html
+  $length = (int)$length;
- *
+  if($length === 0){
- * Unless required by applicable law or agreed to in writing,
+
- * software distributed under the license is distributed on
+  }else if($length > 2000){
- * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+
- * KIND, either express or implied.
+
- *
+  // Note with strpos() - it can return a position of 0 (beginning of the string), so you need to check against the boolean false, to ensure PHP doesn't interprut the 0 as false;
- * Verfication Key: e450edcbe7703e40d9edcf19a18fb4bc
+  if(stripos($case,'lower') !== false){
- */
+
-function cw_randchar($length=NULL,$case=NULL,$spaces=NULL) {
+  }else if(stripos($case, 'upper') !== false){
-  // Removes "," chars if it is a number
+
   }else{
     $characters = "0123456789abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
-    if(strstr($length,",")){
+
-      $length = preg_replace("/[,]*/","",$length);
+  if($spaces){
-      if(!is_numeric($length)){
+    $characters .= ($case)? str_pad('',16,' ') : str_pad('',8,' ');
-        $length = strlen($temp_length);
+
-      }
+  // No need for the is_bool() check as default is false
   $chrLen = strlen($characters) - 1; // Counting the strlen each time, possibly 2000 times, is a waste of resources. (- 1) to remove you blank character errors.
-    elseif(!is_numeric($length)){
+  $rString = ''; //  The return String. Declare before manipulating it, otherwise it will throw Warning Notice
-      $length = strlen($length);
+  for($i=0; $i<$length;++$i){
     $rString .= $characters{mt_rand(0,($chrLen))}; // {} not [] -> [] are for arrays. PHP will process it properly now, but it won't in the future.
   }
-  if($length==NULL||$length==0){
+  return $rString;
-    // Best password length
+}