View difference between Paste ID: Jk06LbfF and uBP1MPat

-(function()
+(function()
 {
-    var paypalButtonData = {};
+    var paypalButtonData;
 
-    var returnDropdownPaypalButton = function( buttonData )
+    var returnPaypalButton = function( buttonData )
     {
-        var costLength = Object.keys(buttonData.cost).length;
+        return  '<form method="post" action="https://www.paypal.com/cgi-bin/webscr" class="paypal-button" target="_top" style="opacity: 1;">' +
                     '<input type="hidden" name="button" value="buynow">' +
-        var priceOptions = '<select name="amount" value="0">';
+
                     '<input type="hidden" name="item_name" value="'+ buttonData.itemName +'">' +
-        for (var i = 0; i < costLength; i++)
+
-        {
+                    '<input type="hidden" name="amount" value="'+ buttonData.cost +'">' +
-            priceOptions += '<option value="' + buttonData.cost[i].cost + '">' + buttonData.cost[i].description + '</option>';
+
                     '<input type="hidden" name="no_shipping" value="' + buttonData.shipping + '">' +
                     '<input type="hidden" name="shipping" value="'+ buttonData.shippingRate +'">' +
-        priceOptions += '</select>';
+
                     '<input type="hidden" name="return" value="http://' + window.location.hostname + '/paypal/checkout' + '">' +
-        return '<form method="post" action="https://www.paypal.com/cgi-bin/webscr" class="paypal-button" target="_top" style="opacity: 1;">' +
+
                     '<input type="hidden" name="notify_url" value="http://' + window.location.hostname + '/paypal/ipn' + '">' +
                     '<input type="hidden" name="cmd" value="_xclick">' +
                     '<input type="hidden" name="bn" value="PP-BuyNowBF:btn_buynowCC_LG.gif:NonHosted">' +
                     '<input type="image" src="https://www.paypalobjects.com/en_US/GB/i/btn/btn_buynowCC_LG.gif" border="0" name="submit" alt="PayPal – The safer, easier way to pay online.">' +
-                    priceOptions +
+
                 '</form>';
     };
 
     CKEDITOR.dialog.add( 'paypalCreateSingleButton', function( editor )
     {
         var lang = editor.lang.paypal;
 
         return {
             title     : CKEDITOR.env.ie ? lang.dlgTitle : lang.title,
-                    '<input type="image" src="https://www.paypalobjects.com/en_US/GB/i/btn/btn_buynowCC_LG.gif" border="0" name="submit" alt="PayPal – The safer, easier way to pay online.">' +
+
             minHeight : 250,
             contents  : [
 
                 {
-    var returnPaymentInputs = function( numberOfInputs )
+
                     label: '',
-        var returnString = '';
+
                     expand: false,
-        for (var i = 0; i < numberOfInputs; i++)
+
-        {
+
-            returnString += '<input data-key="'+i+'" data-property="description" class="cke_dialog_ui_input_text" type="text" placeholder="Item '+ (i + 1) +' Description" style="margin-right:10px;width:60% !important;"><input data-key="'+i+'" data-property="cost" class="cke_dialog_ui_input_text input-xsmall" type="text" placeholder="Item' + (i + 1) +' Price" style="margin-right:10px;width:30% !important;"><br>';
+
                             type: 'text',
                             id: 'CKpaypal-merchantEmail',
-        return returnString;
+
                             validate: function()
                             {
-    CKEDITOR.dialog.add( 'paypalCreateMultiButton', function( editor )
+
                                 {
                                     document.getElementById( 'CKpaypal-validationMessages' ).innerHTML = lang.validateMerchantEmail;
                                     return false;
                                 };
                             },
                             commit: function()
                             {
-            contents: [
+
                             }
                         },
                         {
                             type: 'text',
                             id: 'CKpaypal-itemName',
                             label: lang.labelitemName + ' *',
                             commit: function()
                             {
                                 paypalButtonData.itemName = this.getValue();
                             }
                         },
                         {
                             type: 'select',
                             id: 'CKpaypal-currency',
                             label: lang.labelcurrency + ' *',
                             items: [ ['Please select one:'],['CAD'],['EUR'],['GBP'],['NZD'],['USD'] ],
                             validate: function()
                             {
                                 if( this.getValue() === 'Please select one:' )
                                 {
                                     document.getElementById( 'CKpaypal-validationMessages' ).innerHTML = lang.validatecurrency;
                                     return false;
                                 };
                             },
                             commit: function()
                             {
                                 paypalButtonData.currency = this.getValue();
                             }
                         },
                         {
                             type: 'text',
                             id: 'CKpaypal-price',
                             label: lang.labelprice + ' *',
                             labelStyle: 'margin-top:10px;float:left',
                             inputStyle: 'float:left',
                             commit: function()
                             {
                                 paypalButtonData.cost = this.getValue();
                             }
                         },
                         {
                             type: 'select',
                             id: 'CKpaypal-shipping',
                             label: lang.labelshipping + '*',
                             items: [ ['Please select one:'],['yes'],['no'] ],
                             validate: function()
                             {
                                 if( this.getValue() === 'Please select one:' )
                                 {
                                     document.getElementById( 'CKpaypal-validationMessages' ).innerHTML = lang.validateshipping;
                                     return false;
                                 };
                             },
-                            id: 'CKpaypal-priceOptions',
+
-                            label: lang.labelpriceoptions + ' *',
+
-                            labelStyle: 'margin-top:10px;float:left;',
+
-                            inputStyle: 'margin-top:5px;float:left;width:100%;',
+
-                            items: [ ['Please select the number of price options'], ['1'], ['2'], ['3'], ['4'], ['5'] ],
+
-                            onChange: function( api )
+
                         {
-                                var value = this.getValue(),
+
-                                    priceOptions = '';
+
                             label: lang.labelshippingRate + ' *',
-                                if( value === '' || value === 'Please select the number of price options this item has' )
+
                             inputStyle: 'float:left',
                             commit: function()
                             {
                                 paypalButtonData.shippingRate = ( this.getValue() ? this.getValue() : 0 );
-                                value = parseInt( value );
+
                         },
-                                priceOptions = returnPaymentInputs( value );
+
                             type: 'html',
-                                document.getElementById( 'CKpaypal-priceOptionsContainer' ).innerHTML = priceOptions;
+
-                                return;
+
                     ]
                 }
             ],
-                                paypalButtonData.cost = {};
+
             {
-                                var div    = document.getElementById( 'CKpaypal-priceOptionsContainer' );
+
-                                var inputs = div.getElementsByTagName( 'input' );
+
                 var paypalButton = returnPaypalButton( paypalButtonData );
-                                for (var i = 0; i < inputs.length; i++)
+
                 editor.insertHtml(paypalButton);
-                                    var key      = inputs[i].getAttribute( 'data-key' ),
+
-                                        property = inputs[i].getAttribute( 'data-property' ),
+            },
-                                        value    = inputs[i].value ? inputs[i].value : '0';
+            onShow: function()
             {
-                                    if( !paypalButtonData.cost.hasOwnProperty(key)  )
+                paypalButtonData = {};
-                                    {
+                document.getElementById( 'CKpaypal-validationMessages' ).innerHTML = '';
-                                        paypalButtonData.cost[key] = {};
+
-                                    };
+
         };
-                                    paypalButtonData.cost[key][property] = value;
+
     });
 
 })();