View difference between Paste ID: BPTA5HiF and ReCNKbPN
SHOW: | | - or go back to the newest paste.
1
1 - Migrating users with 'bot: true' attribute to use the new 'type' attribute: https://github.com/RocketChat/Rocket.Chat/blob/7b1e076cbcd6d33eb24dd4cf40e32cce5a62643e/server/startup/migrations/v041.js
2
3-
2 - Even RC Apps still takes accounts with bot type into consideration: https://github.com/RocketChat/Rocket.Chat/blob/7ba14d1efdccd277682f58c820c33946605ab4f5/packages/rocketchat-apps/server/converters/users.js#L49
3+
2 - RC Apps take accounts with bot type into consideration when converting but not anywhere else: https://github.com/RocketChat/Rocket.Chat/blob/7ba14d1efdccd277682f58c820c33946605ab4f5/packages/rocketchat-apps/server/converters/users.js#L49
4
5-
3 - Checks whether a message object has the 'bot' property set. https://github.com/RocketChat/Rocket.Chat/blob/136e9caafedad5bad810d044ef510c5ef09533d6/packages/rocketchat-ui-message/client/message.html#L29 and https://github.com/RocketChat/Rocket.Chat/blob/136e9caafedad5bad810d044ef510c5ef09533d6/packages/rocketchat-ui-message/client/message.js#L19
5+
3 - Integrations take into account events of messages with the 'bot' property set as well as events coming from users with type 'bot', note that the bot role isn't taken into consideration: https://github.com/RocketChat/Rocket.Chat/blob/75d69f05fb129b930b72d638deabfeff545bf990/packages/rocketchat-integrations/server/lib/triggerHandler.js (multiple mentions)
6
7-
4 - Integrations take into account events of messages with the 'bot' property set as well as events coming from users with type 'bot', note that the bot role isn't taken into consideration: https://github.com/RocketChat/Rocket.Chat/blob/75d69f05fb129b930b72d638deabfeff545bf990/packages/rocketchat-integrations/server/lib/triggerHandler.js (multiple mentions)
7+
4 - Two methods querying accounts with user or bot types, not sure what these methods have in special to be the only ones being that specific: https://github.com/RocketChat/Rocket.Chat/blob/fee30ad6f92aa648189757a29b80d1abe78abc40/packages/rocketchat-lib/server/models/Users.js
8
9
5 - Creation of the Rocket.Cat, with bot type: https://github.com/RocketChat/Rocket.Chat/blob/7e25b1ccc9797447aeb2c34208162ed2e9f9bff5/server/startup/initialData.js#L12
10
11-
6 - Query all users with user or bot type, it will be changed to only users type as the bots will be displayed on a different view: https://github.com/RocketChat/Rocket.Chat/blob/9ed7613b7d2eee5dafa2eda9956bd9dc47692a81/packages/rocketchat-ui-admin/client/users/adminUsers.js#L90
11+
6 - Query all users with user or bot type to display the user list, real effect is displaying all users and the rocket.cat bot: https://github.com/RocketChat/Rocket.Chat/blob/9ed7613b7d2eee5dafa2eda9956bd9dc47692a81/packages/rocketchat-ui-admin/client/users/adminUsers.js#L90