View difference between Paste ID: 8HAawh08 and xDvwP6QP

-<?php
+<?php
-
+
-namespace App\Http\Controllers;
+/**
-
+ * 1 - Make all functions public - add [public] keyword before each one
-use App\Post;
+ * 2 - use camelCase name syntax [allData] not [AllData]
-use Illuminate\Http\Request;
+ * 3 - leave some spaces between the variable name and the value
-
+ * 4 - you can use the Validator facade to catch the errors or validate your comming request before doing the logic
-class PostController extends Controller
+ * 5 - you cant return dd() [ dd() for the development things ] instead return response()->json(array $data);
-{
+ * 6 - use request advantage to detrmine if that request is a POST, GET, or PUT request not in the Controller
-    function __construct()
+ *     such as this Route::put('/url', 'SomeController@editUser');
-    {
+ *                  Route::post('/url', 'SomeController@updateUser');
-        $this->middleware('auth')->except(['AllData','show']);
+ *
-    }
+ */
-
+
-    function AllData(){
+namespace App\Http\Controllers;
-        $AllPosts=Post::where('id','>',0)->paginate(5);
+
-        $count=Post::count();
+use App\Post;
-        return view('pages.Home',['posts'=>$AllPosts,'count'=>$count]);
+use Illuminate\Http\Request;
-    }
+
-    function show($id)
+class PostController extends Controller
-    {
+{
-        if (!empty($id)){
+    public function __construct()
-            $post=Post::where('id',$id)->first();
+    {
-            if (count($post)>0){
+        // You don't really need this here
-                return view('pages.showpost',['post'=>$post]);
+        // You can add it to the route - routes/web.php
-            }else{
+        $this->middleware('auth')->except(['AllData','show']);
-                return dd("No post with this id");
+    }
-            }
+
-
+    public function allData(){
-        }else{
+        $posts      = Post::whereId(1)->paginate(5);
-            return dd("Can not be empty");
+        $postsCount = Post::count();
-        }
+
-    }
+        return view('pages.Home', compact('posts', 'postsCount'));
-    function create(){
+    }
-        return view('pages.create');
+
-    }
+    public function show($id)
-    function store(Request $req){
+    {
-        $req->validate([
+        $validator = Validator::make(['id' => $id], [
-            'title' => 'required|max:255',
+            'id' => 'required'
-            'body' => 'required|max:500',
+        ]);
-            'up' => 'image|mimes:jpeg,png,jpg,gif'
+
-        ]);
+        if ($validator->fails()){
-        if ($req->hasFile('up')){
+            return back()->withErrors($validator->errors());
-            $file = $req->file('up');
+        }
-            $exteneion=$file->getClientOriginalExtension();
+
-            $dbfile='image_'.time().date('Y_m_d').".".$exteneion;
+
-            $file->storeAs('public/uploads',$dbfile);
+            $post = Post::findOrFail($id);
-        }else{
+
-            $dbfile = 'noimg.jpg';
+            return view('pages.showpost', compact('post'));
-        }
+    }
-        $post=new Post();
+
-        $post->title = $req->title;
+    public function create(){
-        $post->body = $req->body;
+
-        $post->publisher_name = auth()->user()->name;
+        return view('pages.create');
-        $post->image = $dbfile;
+
-        $post->save();
+    }
-        return redirect('/posts')->with('status','Post inserted');
+
-    }
+    public function store(Request $req){
-    function edit(Request $req,$id)
+
-    {
+        $req->validate([
-        if (!empty($id))
+            'title' => 'required|max:255',
-        {
+            'body' => 'required|max:500',
-            if ($req->isMethod('put')){
+            'up' => 'image|mimes:jpeg,png,jpg,gif'
-                $req->validate([
+        ]);
-                    'title'=>'required|max:255',
+
-                    'body'=>'required|max:500'
+        if ($req->hasFile('up')){
-                ]);
+            $file = $req->file('up');
-                $post=Post::where('id',$id)->first();
+            $exteneion=$file->getClientOriginalExtension();
-                if (auth()->user()->name == $post->publisher_name){
+            $dbfile='image_'.time().date('Y_m_d').".".$exteneion;
-                    $post->title=$req->title;
+            $file->storeAs('public/uploads',$dbfile);
-                    $post->body=$req->body;
+        } else {
-                    $post->save();
+            $dbfile = 'noimg.jpg';
-                    return redirect('posts')->with('status','post Updated');
+        }
-                } else{
+
-                    return redirect('/posts')->with('error','You can not edit these post');
+        $post = new Post();
-                }
+        $post->title = $req->title;
-
+        $post->body = $req->body;
-            }else{
+        $post->publisher_name = auth()->user()->name;
-                $post=Post::where('id',$id)->first();
+        $post->image = $dbfile;
-                if (!count($post)>0){
+        $post->save();
-                    return dd("No Post With this id");
+
-                }else{
+        return redirect('/posts')->with('status','Post inserted');
-                    if (auth()->user()->name == $post->publisher_name){
+    }
-                        return view('pages.editpost',['post'=>$post]);
+
-                    }
+    public function edit(Request $req, $id)
-                    else{
+    {
-                        return redirect('/posts')->with('error','You can not edit these post');
+        $validator = Validator::make(['id' => $id], [
-                    }
+            'id' => 'required'
-                }
+        ]);
-
+
-            }
+        if ($validator->fails()){
-
+            return back()->withErrors($validator->errors());
-
+        }
-        }
+
-    }
+        if ($req->isMethod('put')){
-    function delete($id){
+            $req->validate([
-        if (!empty($id)){
+                'title'=>'required|max:255',
-            $post=Post::where('id',$id)->first();
+                'body'=>'required|max:500'
-            if (count($post)>0){
+            ]);
-                if (auth()->user()->name == $post->publisher_name){
+            $post = Post::findOfFail($id);
-                    if ((!empty($post->image) || $post->image != null) && $post->image != "noimg.jpg" ){
+
-                        unlink('storage/uploads/'.$post->image);
+            if (auth()->user()->name == $post->publisher_name){
-                    }
+                $post->title=$req->title;
-                    $post->delete();
+                $post->body=$req->body;
-                    return redirect('/posts')->with('status','Post Deleted');
+                $post->save();
-                }
+                return redirect('posts')->with('status','post Updated');
-                else{
+            } else{
-                    return redirect('/posts')->with('error','You can not delete these post');
+                return redirect('/posts')->with('error','You can not edit these post');
-                }
+            }
-            }else{
+
-                return dd("No post With this id");
+        } else {
-            }
+
-        }
+            $post = Post::findOrFail($id);
-    }
+
             if (auth()->user()->name == $post->publisher_name){
                 return view('pages.editpost',['post'=>$post]);
             }
             else{
                 return redirect('/posts')->with('error','You can not edit these post');
             }
 
 
         }
     }
 
     public function delete($id){
         $validator = Validator::make(['id' => $id], [
             'id' => 'required'
         ]);
 
         if ($validator->fails()){
             return back()->withErrors($validator->errors());
         }
 
         $post = Post::findOrFail($id);
 
         if (auth()->user()->name == $post->publisher_name){
             if ((!empty($post->image) || $post->image != null) && $post->image != "noimg.jpg" ){
                 unlink('storage/uploads/'.$post->image);
             }
             $post->delete();
             return redirect('/posts')->with('status','Post Deleted');
         }
         else{
             return redirect('/posts')->with('error','You can not delete these post');
         }
     }
 }