PVS-StudioWarnings

PVS-Studio warning V501 for Firefox

Nov 17th, 2014
179
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.79 KB | None | 0 0
  1. static PRBool IsZPositionLEQ(nsDisplayItem* aItem1,
  2.                              nsDisplayItem* aItem2,
  3.                              void* aClosure) {
  4.   if (!aItem1->GetUnderlyingFrame()->Preserves3D() ||
  5.       !aItem1->GetUnderlyingFrame()->Preserves3D()) {
  6.     return IsContentLEQ(aItem1, aItem2, aClosure);
  7.   }
  8.   ...
  9. }
  10.  
  11. Most likely this is what should be written here: !aItem1->.... || !aItem2->....
  12.  
  13. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V501 There are identical sub-expressions to the left and to the right of the '||' operator. nsdisplaylist.cpp 767
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment