PVS-StudioWarnings

PVS-Studio warning V528 for Apache

Nov 20th, 2014
159
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. typedef struct {
  2.   ....
  3.   const char **re_source;
  4.   ....
  5. } ap_expr_eval_ctx_t;
  6.  
  7. static const char *ap_expr_eval_re_backref(
  8.   ap_expr_eval_ctx_t *ctx, unsigned int n)
  9. {
  10.   int len;
  11.   if (!ctx->re_pmatch || !ctx->re_source ||
  12.       *ctx->re_source == '\0' ||
  13.       ctx->re_nmatch < n + 1)
  14.     return "";
  15.   ....
  16. }
  17.  
  18. This suspicious code was found in Apache project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V528 It is odd that pointer to 'char' type is compared with the '\0' value. Probably meant: ** ctx->re_source == '\0'. libhttpd util_expr_eval.c 167
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment