Create a new version of paste:

Index: attica/lib/atticabasejob.h
===================================================================
--- attica/lib/atticabasejob.h	(revision 1107607)
+++ attica/lib/atticabasejob.h	(working copy)
@@ -72,7 +72,7 @@
     BaseJob& operator=(const BaseJob& other);
 
     class Private;
-    Private* d;
+    Private * const d;
 };
 
 }
Index: attica/lib/knowledgebaseentry.h
===================================================================
--- attica/lib/knowledgebaseentry.h	(revision 1107607)
+++ attica/lib/knowledgebaseentry.h	(working copy)
@@ -28,7 +28,7 @@
 #include <QtCore/QDateTime>
 #include <QtCore/QSharedDataPointer>
 
-#include <QUrl>
+#include <QtCore/QUrl>
 
 
 namespace Attica
Index: attica/lib/content.cpp
===================================================================
--- attica/lib/content.cpp	(revision 1107607)
+++ attica/lib/content.cpp	(working copy)
@@ -174,7 +174,7 @@
     QMap<QString,QString>::const_iterator iter = d->m_extendedAttributes.constBegin();
     while (iter != d->m_extendedAttributes.constEnd()) {
         QString key = iter.key();
-        if (key.startsWith("downloadname")) {
+        if (key.startsWith(QLatin1String("downloadname"))) {
             bool ok;
             // remove "downloadlink", get the rest as number
             int num = key.right(key.size() - 12).toInt(&ok);
Index: attica/lib/getjob.cpp
===================================================================
--- attica/lib/getjob.cpp	(revision 1107607)
+++ attica/lib/getjob.cpp	(working copy)
@@ -31,15 +31,28 @@
 using namespace Attica;
 
 
+class Attica::GetJobPrivate
+{
+public:
+    GetJobPrivate(const QNetworkRequest& request)
+        : m_request(request) {}
+
+    const QNetworkRequest m_request;
+};
+
 GetJob::GetJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request)
-    : BaseJob(internals), m_request(request)
+    : BaseJob(internals), d(new GetJobPrivate(request))
 {
 }
 
+GetJob::~GetJob()
+{
+    delete d;
+}
 
 QNetworkReply* GetJob::executeRequest()
 {
-    return internals()->get(m_request);
+    return internals()->get(d->m_request);
 }
 
 
Index: attica/lib/content.h
===================================================================
--- attica/lib/content.h	(revision 1107607)
+++ attica/lib/content.h	(working copy)
@@ -27,10 +27,10 @@
 #include <QtCore/QString>
 #include <QtCore/QMap>
 #include <QtCore/QSharedDataPointer>
+#include <QtCore/QUrl>
 
 #include "atticaclient_export.h"
 #include "downloaddescription.h"
-#include <qurl.h>
 
 class QDateTime;
 
Index: attica/lib/postjob.cpp
===================================================================
--- attica/lib/postjob.cpp	(revision 1107607)
+++ attica/lib/postjob.cpp	(working copy)
@@ -33,38 +33,64 @@
 
 using namespace Attica;
 
+class Attica::PostJobPrivate
+{
+public:
+    PostJobPrivate(const QNetworkRequest& request, QIODevice* iodevice)
+        : m_request(request), m_ioDevice(iodevice)
+    {
+    }
+    PostJobPrivate(const QNetworkRequest& request, QIODevice* iodevice, const QByteArray& byteArray)
+        : m_request(request), m_ioDevice(iodevice), m_byteArray(byteArray)
+    {
+    }
 
+    QIODevice* m_ioDevice;
+    QByteArray m_byteArray;
+
+    QString m_responseData;
+    const QNetworkRequest m_request;
+
+    QString m_status;
+    QString m_statusMessage;
+};
+
 PostJob::PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, QIODevice* iodevice)
-    : BaseJob(internals), m_ioDevice(iodevice), m_request(request)
+    : BaseJob(internals), d(new PostJobPrivate(request, iodevice))
 {
 }
 
 Attica::PostJob::PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, const QByteArray& byteArray)
-    : BaseJob(internals), m_ioDevice(0) , m_byteArray(byteArray), m_request(request)
+    : BaseJob(internals), d(new PostJobPrivate(request, 0, byteArray))
 {
 }
 
 PostJob::PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, const StringMap& parameters)
-    : BaseJob(internals), m_ioDevice(0), m_request(request)
+    : BaseJob(internals), d(new PostJobPrivate(request, 0))
 {
     // Create post data
     int j = 0;
     for(StringMap::const_iterator i = parameters.begin(); i != parameters.end(); ++i) {
         if (j++ > 0) {
-            m_byteArray.append('&');
+            d->m_byteArray.append('&');
         }
-        m_byteArray.append(QUrl::toPercentEncoding(i.key()));
-        m_byteArray.append('=');
-        m_byteArray.append(QUrl::toPercentEncoding(i.value()));
+        d->m_byteArray.append(QUrl::toPercentEncoding(i.key()));
+        d->m_byteArray.append('=');
+        d->m_byteArray.append(QUrl::toPercentEncoding(i.value()));
     }
 }
 
+PostJob::~PostJob()
+{
+    delete d;
+}
+
 QNetworkReply* PostJob::executeRequest()
 {
-    if (m_ioDevice) {
-        return internals()->post(m_request, m_ioDevice);
+    if (d->m_ioDevice) {
+        return internals()->post(d->m_request, d->m_ioDevice);
     } else {
-        return internals()->post(m_request, m_byteArray);
+        return internals()->post(d->m_request, d->m_byteArray);
     }
 }
 
Index: attica/lib/metadata.h
===================================================================
--- attica/lib/metadata.h	(revision 1107607)
+++ attica/lib/metadata.h	(working copy)
@@ -25,7 +25,7 @@
 
 #include <QtCore/QString>
 
-#include <QSharedDataPointer>
+#include <QtCore/QSharedDataPointer>
 
 #include "atticaclient_export.h"
 
Index: attica/lib/provider.cpp
===================================================================
--- attica/lib/provider.cpp	(revision 1107607)
+++ attica/lib/provider.cpp	(working copy)
@@ -616,7 +616,7 @@
     QNetworkRequest request(url);
 
     if (!d->m_credentialsUserName.isEmpty()) {
-        QString concatenated = d->m_credentialsUserName + ":" + d->m_credentialsPassword;
+        QString concatenated = d->m_credentialsUserName + ':' + d->m_credentialsPassword;
         QByteArray data = concatenated.toLocal8Bit().toBase64();
         QString headerData = "Basic " + data;
         request.setRawHeader("Authorization", headerData.toLocal8Bit());
Index: attica/lib/getjob.h
===================================================================
--- attica/lib/getjob.h	(revision 1107607)
+++ attica/lib/getjob.h	(working copy)
@@ -32,16 +32,19 @@
 
 namespace Attica {
 
+class GetJobPrivate;
+
 class ATTICA_EXPORT GetJob : public Attica::BaseJob
 {
     Q_OBJECT
 
 protected:
     GetJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request);
+    ~GetJob();
     
 private:
     virtual QNetworkReply* executeRequest();
-    const QNetworkRequest m_request;
+    GetJobPrivate * const d;
 };
 
 }
Index: attica/lib/postjob.h
===================================================================
--- attica/lib/postjob.h	(revision 1107607)
+++ attica/lib/postjob.h	(working copy)
@@ -33,8 +33,11 @@
 typedef QMap<QString, QString> StringMap;
 
 namespace Attica {
-    class Provider;
 
+class Provider;
+
+class PostJobPrivate;
+
 class ATTICA_EXPORT PostJob : public BaseJob
 {
     Q_OBJECT
@@ -43,19 +46,13 @@
     PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, QIODevice* data);
     PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, const StringMap& parameters = StringMap());
     PostJob(const QSharedPointer<PlatformDependent>& internals, const QNetworkRequest& request, const QByteArray& byteArray);
+    ~PostJob();
 
 private:
     virtual QNetworkReply* executeRequest();
     virtual void parse(const QString&);
 
-    QIODevice* m_ioDevice;
-    QByteArray m_byteArray;
-    
-    QString m_responseData;
-    const QNetworkRequest m_request;
-  
-    QString m_status;
-    QString m_statusMessage;
+    PostJobPrivate * const d;
 
     friend class Attica::Provider;
 };
Index: attica/lib/provider.h
===================================================================
--- attica/lib/provider.h	(revision 1107607)
+++ attica/lib/provider.h	(working copy)
@@ -28,7 +28,7 @@
 #include <QtCore/QSharedPointer>
 #include <QtCore/QString>
 
-#include <QUrl>
+#include <QtCore/QUrl>
 
 #include "atticaclient_export.h"
 #include "category.h"
@@ -62,7 +62,7 @@
  * The Provider class represents one Open Collaboration Service provider.
  * Use the ProviderManager to instanciate a Provider.
  *
- * Accessing funtions of the Provider returns a Job class that
+ * Accessing functions of the Provider returns a Job class that
  * takes care of accessing the server and parsing the result.
  */
 class ATTICA_EXPORT Provider